From a07377be0fa8fbd60d404d5c19e836296f6a4255 Mon Sep 17 00:00:00 2001 From: c-bata Date: Sun, 11 Apr 2021 18:46:57 +0900 Subject: [PATCH] Fix integration tests --- .github/workflows/integration-tests.yml | 2 +- visual_regression_test.py | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/integration-tests.yml b/.github/workflows/integration-tests.yml index 4066a408..e8a688c1 100644 --- a/.github/workflows/integration-tests.yml +++ b/.github/workflows/integration-tests.yml @@ -46,6 +46,6 @@ jobs: env: PYPPETEER_HOME: ./local-chromium - - run: python visual_regression_test.py --no-screenshot --sleep 3 + - run: python visual_regression_test.py --skip-screenshot --sleep 3 env: PYPPETEER_HOME: ./local-chromium diff --git a/visual_regression_test.py b/visual_regression_test.py index 600cf21e..392e179d 100644 --- a/visual_regression_test.py +++ b/visual_regression_test.py @@ -165,9 +165,10 @@ async def take_screenshots(storage: optuna.storages.BaseStorage) -> List[str]: page = await browser.newPage() await page.setViewport({"width": args.width, "height": args.height}) - await page.goto(f"http://{args.host}:{args.port}/dashboard/") - time.sleep(1) - await page.screenshot({"path": os.path.join(args.output_dir, "study-list.png")}) + if not args.skip_screenshot: + await page.goto(f"http://{args.host}:{args.port}/dashboard/") + time.sleep(1) + await page.screenshot({"path": os.path.join(args.output_dir, "study-list.png")}) study_ids = {s._study_id: s.study_name for s in storage.get_all_study_summaries()} for study_id, study_name in study_ids.items():