wassname/optuna-dashboard
1
0
Fork 0
mirror of https://github.com/wassname/optuna-dashboard.git synced 2026-09-22 13:20:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix by review

Browse Source
This commit is contained in:
moririn2528
2023-09-11 16:31:39 +09:00
parent 23db3e7c4e
commit b0ed82af7e
6 changed files with 38 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python_tests/test_api.py
+2 -12
View File
@@ -234,12 +234,7 @@ class APITestCase(TestCase):
status, _, _ = send_request(
app,
f"/api/studies/{study_id}/preference/{history_id}",
"PUT",
body=json.dumps(
{
"enable": False,
}
),
"DELETE",
content_type="application/json",
)
self.assertEqual(status, 204)
@@ -251,12 +246,7 @@ class APITestCase(TestCase):
status, _, _ = send_request(
app,
f"/api/studies/{study_id}/preference/{history_id}",
"PUT",
body=json.dumps(
{
"enable": True,
}
),
"POST",
content_type="application/json",
)
self.assertEqual(status, 204)
python_tests/test_preferential_history.py
+6 -5
View File
@@ -6,8 +6,9 @@ from typing import TYPE_CHECKING
from optuna_dashboard._preferential_history import _SYSTEM_ATTR_PREFIX_HISTORY
from optuna_dashboard._preferential_history import NewHistory
from optuna_dashboard._preferential_history import remove_history
from optuna_dashboard._preferential_history import report_history
from optuna_dashboard._preferential_history import switching_history
from optuna_dashboard._preferential_history import restore_history
from optuna_dashboard._serializer import serialize_preference_history
from optuna_dashboard.preferential import create_study
from optuna_dashboard.preferential._system_attrs import _SYSTEM_ATTR_PREFIX_PREFERENCE
@@ -86,18 +87,18 @@ def test_undo_redo_history(storage_supplier: Callable[[], StorageSupplier]) -> N
storage=storage,
input_data=NewHistory(mode="ChooseWorst", candidates=[0, 1, 2], clicked=1),
)
switching_history(study_id, storage, history_id, False)
remove_history(study_id, storage, history_id)
preference, history = get_preferences_history(history_id)
assert history["mode"] == "ChooseWorst"
assert history["candidates"] == [0, 1, 2]
assert history["clicked"] == 1
assert len(preference) == 0
switching_history(study_id, storage, history_id, False)
remove_history(study_id, storage, history_id)
preference, history = get_preferences_history(history_id)
assert len(preference) == 0
switching_history(study_id, storage, history_id, True)
restore_history(study_id, storage, history_id)
preference, history = get_preferences_history(history_id)
assert history["mode"] == "ChooseWorst"
assert history["candidates"] == [0, 1, 2]
@@ -108,6 +109,6 @@ def test_undo_redo_history(storage_supplier: Callable[[], StorageSupplier]) -> N
assert preference[i][0] == best
assert preference[i][1] == worst
switching_history(study_id, storage, history_id, True)
restore_history(study_id, storage, history_id)
preference, history = get_preferences_history(history_id)
assert len(preference) == 2