From ba96fd624b9c81faab712e7169333047602b7477 Mon Sep 17 00:00:00 2001 From: c-bata Date: Thu, 24 Mar 2022 12:34:58 +0900 Subject: [PATCH] Set include_best_trial=True for v3 release --- optuna_dashboard/_app.py | 13 ++++++++----- setup.cfg | 1 + 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/optuna_dashboard/_app.py b/optuna_dashboard/_app.py index 167a6ed6..8ec201b1 100644 --- a/optuna_dashboard/_app.py +++ b/optuna_dashboard/_app.py @@ -30,6 +30,8 @@ from optuna.storages import RedisStorage from optuna.study import StudyDirection from optuna.study import StudySummary from optuna.trial import FrozenTrial +from optuna.version import __version__ as optuna_ver +from packaging import version from . import _note as note from ._importance import get_param_importance_from_trials_cache @@ -121,12 +123,13 @@ def create_app(storage: BaseStorage, debug: bool = False) -> Bottle: @app.get("/api/studies") @json_api_view def list_study_summaries() -> BottleViewReturn: - summaries = [ - serialize_study_summary(summary) - for summary in storage.get_all_study_summaries() - ] + if version.parse(optuna_ver) >= version.Version("3.0.0b0"): + summaries = storage.get_all_study_summaries(include_best_trial=True) + else: + summaries = storage.get_all_study_summaries() + serialized = [serialize_study_summary(summary) for summary in summaries] return { - "study_summaries": summaries, + "study_summaries": serialized, } @app.post("/api/studies") diff --git a/setup.cfg b/setup.cfg index c9886d70..3b084284 100644 --- a/setup.cfg +++ b/setup.cfg @@ -29,6 +29,7 @@ include_package_data = False packages = find: install_requires = optuna>=2.4 + packaging bottle typing-extensions;python_version<'3.8' scikit-learn