From be2c3340e5730a71e511a893ba243292c8f0e5ff Mon Sep 17 00:00:00 2001 From: keisuke-umezawa Date: Mon, 8 Jan 2024 13:37:54 +0900 Subject: [PATCH] Clear inmemory chache when terminating test --- .../test_usecases/test_preferential_optimization.py | 2 -- e2e_tests/test_dashboard/test_usecases/test_study_history.py | 2 -- e2e_tests/test_dashboard/visual_regression_test.py | 2 -- e2e_tests/test_server.py | 3 +++ 4 files changed, 3 insertions(+), 6 deletions(-) diff --git a/e2e_tests/test_dashboard/test_usecases/test_preferential_optimization.py b/e2e_tests/test_dashboard/test_usecases/test_preferential_optimization.py index 0b19fea0..fa3317dc 100644 --- a/e2e_tests/test_dashboard/test_usecases/test_preferential_optimization.py +++ b/e2e_tests/test_dashboard/test_usecases/test_preferential_optimization.py @@ -9,7 +9,6 @@ from playwright.sync_api import Page import pytest from ...test_server import make_test_server -from ...utils import clear_inmemory_cache def make_test_storage() -> optuna.storages.InMemoryStorage: @@ -44,7 +43,6 @@ def make_test_storage() -> optuna.storages.InMemoryStorage: @pytest.fixture def storage() -> optuna.storages.InMemoryStorage: - clear_inmemory_cache() storage = make_test_storage() return storage diff --git a/e2e_tests/test_dashboard/test_usecases/test_study_history.py b/e2e_tests/test_dashboard/test_usecases/test_study_history.py index f2d937bb..6c22b16b 100644 --- a/e2e_tests/test_dashboard/test_usecases/test_study_history.py +++ b/e2e_tests/test_dashboard/test_usecases/test_study_history.py @@ -3,7 +3,6 @@ from playwright.sync_api import Page import pytest from ...test_server import make_test_server -from ...utils import clear_inmemory_cache def make_test_storage() -> optuna.storages.InMemoryStorage: @@ -24,7 +23,6 @@ def make_test_storage() -> optuna.storages.InMemoryStorage: @pytest.fixture def storage() -> optuna.storages.InMemoryStorage: - clear_inmemory_cache() storage = make_test_storage() return storage diff --git a/e2e_tests/test_dashboard/visual_regression_test.py b/e2e_tests/test_dashboard/visual_regression_test.py index ab189343..ea6ff930 100644 --- a/e2e_tests/test_dashboard/visual_regression_test.py +++ b/e2e_tests/test_dashboard/visual_regression_test.py @@ -5,12 +5,10 @@ from playwright.sync_api import Page import pytest from ..test_server import make_test_server -from ..utils import clear_inmemory_cache @pytest.fixture def storage() -> optuna.storages.InMemoryStorage: - clear_inmemory_cache() storage = optuna.storages.InMemoryStorage() return storage diff --git a/e2e_tests/test_server.py b/e2e_tests/test_server.py index a15acc68..cbf65a29 100644 --- a/e2e_tests/test_server.py +++ b/e2e_tests/test_server.py @@ -8,6 +8,8 @@ import optuna from optuna_dashboard import wsgi import pytest +from .utils import clear_inmemory_cache + def get_free_port() -> int: tcp = socket.socket(socket.AF_INET, socket.SOCK_STREAM) @@ -28,6 +30,7 @@ def make_test_server( thread.start() def stop_server() -> None: + clear_inmemory_cache() httpd.shutdown() httpd.server_close() thread.join()