From e85ed2a13a89c167e98de27cff8bf02c9ff143d3 Mon Sep 17 00:00:00 2001 From: c-bata Date: Tue, 1 Feb 2022 22:51:37 +0900 Subject: [PATCH 1/3] Add IntDistribution & FloatDistribution --- .../static/components/GraphHyperparameterImportances.tsx | 2 ++ optuna_dashboard/static/types/index.d.ts | 2 ++ 2 files changed, 4 insertions(+) diff --git a/optuna_dashboard/static/components/GraphHyperparameterImportances.tsx b/optuna_dashboard/static/components/GraphHyperparameterImportances.tsx index 4595effb..888a5eda 100644 --- a/optuna_dashboard/static/components/GraphHyperparameterImportances.tsx +++ b/optuna_dashboard/static/components/GraphHyperparameterImportances.tsx @@ -39,9 +39,11 @@ const plotlyColorsSequentialBlues = [ ] const distributionColors = { + FloatDistribution: plotlyColorsSequentialBlues.slice(-1)[0], UniformDistribution: plotlyColorsSequentialBlues.slice(-1)[0], LogUniformDistribution: plotlyColorsSequentialBlues.slice(-1)[0], DiscreteUniformDistribution: plotlyColorsSequentialBlues.slice(-1)[0], + IntDistribution: plotlyColorsSequentialBlues.slice(-2)[0], IntUniformDistribution: plotlyColorsSequentialBlues.slice(-2)[0], IntLogUniformDistribution: plotlyColorsSequentialBlues.slice(-2)[0], CategoricalDistribution: plotlyColorsSequentialBlues.slice(-4)[0], diff --git a/optuna_dashboard/static/types/index.d.ts b/optuna_dashboard/static/types/index.d.ts index 6eb7279c..614b78f0 100644 --- a/optuna_dashboard/static/types/index.d.ts +++ b/optuna_dashboard/static/types/index.d.ts @@ -10,6 +10,8 @@ declare const URL_PREFIX: string type TrialState = "Running" | "Complete" | "Pruned" | "Fail" | "Waiting" type StudyDirection = "maximize" | "minimize" | "not_set" type Distribution = + | "FloatDistribution" + | "IntDistribution" | "UniformDistribution" | "LogUniformDistribution" | "DiscreteUniformDistribution" From 9a24f7d549ef9b2bcfbc0b8a2370c3309712692e Mon Sep 17 00:00:00 2001 From: c-bata Date: Tue, 1 Feb 2022 23:13:13 +0900 Subject: [PATCH 2/3] Add todo comment for log scale check --- optuna_dashboard/static/components/GraphSlice.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/optuna_dashboard/static/components/GraphSlice.tsx b/optuna_dashboard/static/components/GraphSlice.tsx index cb4bd055..91534c7b 100644 --- a/optuna_dashboard/static/components/GraphSlice.tsx +++ b/optuna_dashboard/static/components/GraphSlice.tsx @@ -26,6 +26,7 @@ const useStyles = makeStyles((theme: Theme) => }) ) +// TODO(c-bata): Check `log` field of IntDistribution and FloatDistribution. const logDistributions = ["LogUniformDistribution", "IntLogUniformDistribution"] export const GraphSlice: FC<{ From 8c4a09d835a9601c389365caa4f4b0a0e925bc67 Mon Sep 17 00:00:00 2001 From: c-bata Date: Tue, 1 Feb 2022 23:15:57 +0900 Subject: [PATCH 3/3] Replace UniformDistribution with FloatDistribution in frontend tests --- frontend_tests/TrialTable.test.tsx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/frontend_tests/TrialTable.test.tsx b/frontend_tests/TrialTable.test.tsx index f6a9a7d9..4ddd6fc3 100644 --- a/frontend_tests/TrialTable.test.tsx +++ b/frontend_tests/TrialTable.test.tsx @@ -52,24 +52,24 @@ const study_detail = { intersection_search_space: [ { name: "x", - distribution: "UniformDistribution" as Distribution, + distribution: "FloatDistribution" as Distribution, attributes: { low: -3, high: 3 }, }, { name: "y", - distribution: "UniformDistribution" as Distribution, + distribution: "FloatDistribution" as Distribution, attributes: { low: -3, high: 3 }, }, ], union_search_space: [ { name: "x", - distribution: "UniformDistribution" as Distribution, + distribution: "FloatDistribution" as Distribution, attributes: { low: -3, high: 3 }, }, { name: "y", - distribution: "UniformDistribution" as Distribution, + distribution: "FloatDistribution" as Distribution, attributes: { low: -3, high: 3 }, }, ],