From c2751cb3ec901eaef794f3e540dcd7e7e7c1c0d6 Mon Sep 17 00:00:00 2001 From: keisuke-umezawa Date: Wed, 29 May 2024 21:29:18 +0900 Subject: [PATCH] Follow review comments --- CONTRIBUTING.md | 6 +++--- Makefile | 10 +++++----- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index a79462bd..81adb196 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -86,13 +86,13 @@ Note that `OPTUNA_DASHBOARD_DEBUG=1` makes the server will automatically restart ### Running tests, lint checks and formatters -#### Running typescript unit tests +#### Running unit tests for `tslib/` ``` -$ make tstest +$ make tslib-test ``` -#### Running Python unit tests +#### Running unit tests for `python_tests/` ``` $ pytest python_tests/ diff --git a/Makefile b/Makefile index 3673f901..f44ce36a 100644 --- a/Makefile +++ b/Makefile @@ -18,17 +18,17 @@ vscode/assets/bundle.js: $(RUSTLIB_OUT) $(STANDALONE_SRC) tslib $(DASHBOARD_TS_OUT): $(DASHBOARD_TS_SRC) cd optuna_dashboard && npm install && npm run build:$(MODE) -.PHONY: tstest -tstest: tslib - cd tslib/react/test && python generate_assets.py && npm run test - cd tslib/storage/test && python generate_assets.py && npm run test - .PHONY: tslib tslib: cd tslib/types && npm i && npm run build cd tslib/storage && npm i && npm run build cd tslib/react && npm i && npm run build +.PHONY: tslib-test +tslib-test: tslib + cd tslib/react/test && python generate_assets.py && npm run test + cd tslib/storage/test && python generate_assets.py && npm run test + .PHONY: serve-browser-app serve-browser-app: tslib $(RUSTLIB_OUT) cd standalone_app && npm run watch