From c822e3450cfc16d0d88fcf202d6a7fd70313130f Mon Sep 17 00:00:00 2001
From: keisuke umezawa <keisuke-umezawa@users.noreply.github.com>
Date: Wed, 25 Jan 2023 20:58:52 +0900
Subject: [PATCH] Apply suggestions from code review

Co-authored-by: Hiroyuki Vincent Yamazaki <hiroyuki.vincent.yamazaki@gmail.com>
---
 optuna_dashboard/_app.py                      | 2 +-
 optuna_dashboard/ts/action.ts                 | 4 ++--
 optuna_dashboard/ts/components/TrialTable.tsx | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/optuna_dashboard/_app.py b/optuna_dashboard/_app.py
index 9061959a..f6d43a79 100644
--- a/optuna_dashboard/_app.py
+++ b/optuna_dashboard/_app.py
@@ -436,7 +436,7 @@ def create_app(storage: BaseStorage, debug: bool = False) -> Bottle:
                 values = [float(v) for v in vs]
             except (ValueError, TypeError):
                 response.status = 400  # Bad request
-                return {"reason": "values attribute must be number's array"}
+                return {"reason": "values attribute must be an array of numbers"}
 
         try:
             storage.set_trial_state_values(trial_id, state, values)
diff --git a/optuna_dashboard/ts/action.ts b/optuna_dashboard/ts/action.ts
index 4eb70203..0587efcd 100644
--- a/optuna_dashboard/ts/action.ts
+++ b/optuna_dashboard/ts/action.ts
@@ -50,7 +50,7 @@ export const actionCreator = () => {
     setStudyDetailState(studyId, newStudy)
   }
 
-  const setTrialState = (
+  const setTrialStateValues = (
     studyId: number,
     index: number,
     state: TrialState,
@@ -307,7 +307,7 @@ export const actionCreator = () => {
           return
         }
         setTrialState(studyId, index, state, values)
-        enqueueSnackbar(`Success to update trial (${message})`, {
+        enqueueSnackbar(`Successfully updated trial (${message})`, {
           variant: "success",
         })
       })
diff --git a/optuna_dashboard/ts/components/TrialTable.tsx b/optuna_dashboard/ts/components/TrialTable.tsx
index 6616af7f..ce83d920 100644
--- a/optuna_dashboard/ts/components/TrialTable.tsx
+++ b/optuna_dashboard/ts/components/TrialTable.tsx
@@ -341,7 +341,7 @@ export const TrialTable: FC<{
           <Grid item xs={12}>
             <Box margin={1}>
               <Typography variant="h6" gutterBottom component="div">
-                Trial tell operations
+                Trial tell
               </Typography>
               <form onSubmit={handleSubmit}>
                 <Box margin={1}>