wassname/optuna-dashboard
1
0
Fork 0
mirror of https://github.com/wassname/optuna-dashboard.git synced 2026-09-09 11:28:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix a bug that boto3.upload_fileobj may close the file

Browse Source
This commit is contained in:
c-bata
2023-06-13 03:30:02 +09:00
parent ad7613d19d
commit ca5bf5f315
2 changed files with 19 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python_tests/artifact/test_boto3.py
+3 -1
View File
@@ -26,9 +26,10 @@ class Boto3BackendTestCase(TestCase):
def test_upload_download(self) -> None:
artifact_id = "dummy-uuid"
dummy_content = b"Hello World"
buf = io.BytesIO(dummy_content)
backend = Boto3Backend(self.bucket_name)
backend.write(artifact_id, io.BytesIO(dummy_content))
backend.write(artifact_id, buf)
assert len(self.s3_client.list_objects(Bucket=self.bucket_name)["Contents"]) == 1
obj = self.s3_client.get_object(Bucket=self.bucket_name, Key=artifact_id)
assert obj["Body"].read() == dummy_content
@@ -36,6 +37,7 @@ class Boto3BackendTestCase(TestCase):
with backend.open(artifact_id) as f:
actual = f.read()
self.assertEqual(actual, dummy_content)
self.assertFalse(buf.closed)
def test_remove(self) -> None:
artifact_id = "dummy-uuid"