From dae5f8f6e74363d5dddff395bb1a4b846f64e201 Mon Sep 17 00:00:00 2001 From: Shinichi Hemmi <50256998+Alnusjaponica@users.noreply.github.com> Date: Sat, 19 Aug 2023 16:42:15 +0900 Subject: [PATCH] Remove unnecessary search in trial_system_attr --- optuna_dashboard/artifact/_backend.py | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/optuna_dashboard/artifact/_backend.py b/optuna_dashboard/artifact/_backend.py index 5f0ba261..7a9f1242 100644 --- a/optuna_dashboard/artifact/_backend.py +++ b/optuna_dashboard/artifact/_backend.py @@ -131,9 +131,6 @@ def register_artifact_route( storage.set_study_system_attr( study_id, _artifact_prefix(trial_id) + artifact_id, json.dumps(None) ) - storage.set_trial_system_attr( - trial_id, DASHBOARD_ARTIFACTS_ATTR_PREFIX + artifact_id, json.dumps(None) - ) storage.set_trial_system_attr( trial_id, ARTIFACTS_ATTR_PREFIX + artifact_id, json.dumps(None) ) @@ -216,9 +213,7 @@ def get_artifact_meta( # have a different trial_system_attrs key prefix. # See https://github.com/optuna/optuna/blob/f827582a8/optuna/artifacts/_upload.py#L71 trial_system_attrs = storage.get_trial_system_attrs(trial_id) - value = trial_system_attrs.get( - DASHBOARD_ARTIFACTS_ATTR_PREFIX + artifact_id - ) or trial_system_attrs.get(ARTIFACTS_ATTR_PREFIX + artifact_id) + value = trial_system_attrs.get(ARTIFACTS_ATTR_PREFIX + artifact_id) if value is not None: return json.loads(value) @@ -252,7 +247,7 @@ def list_trial_artifacts( optuna_artifact_metas = [ json.loads(value) for key, value in trial.system_attrs.items() - if key.startswith(ARTIFACTS_ATTR_PREFIX) or key.startswith(DASHBOARD_ARTIFACTS_ATTR_PREFIX) + if key.startswith(ARTIFACTS_ATTR_PREFIX) ] artifact_metas = dashboard_artifact_metas + optuna_artifact_metas return [a for a in artifact_metas if a is not None]