From db455f8b64507dc829bf33e6f25e80c1032622a8 Mon Sep 17 00:00:00 2001 From: c-bata Date: Fri, 9 Dec 2022 10:49:15 +0900 Subject: [PATCH] Fix a mypy error and add a test case --- python_tests/test_cached_extra_study_property.py | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/python_tests/test_cached_extra_study_property.py b/python_tests/test_cached_extra_study_property.py index e516190b..bf21416b 100644 --- a/python_tests/test_cached_extra_study_property.py +++ b/python_tests/test_cached_extra_study_property.py @@ -1,3 +1,4 @@ +from typing import Any from typing import Dict from typing import List from unittest import TestCase @@ -118,7 +119,7 @@ class _CachedExtraStudyPropertySearchSpaceTestCase(TestCase): self.assertEqual(len(cached_extra_study_property.union), 3) def test_contains_failed_trials(self) -> None: - distributions = { + distributions: Dict[str, BaseDistribution] = { "x0": FloatDistribution(low=0, high=10), "x1": FloatDistribution(low=0, high=10), } @@ -215,7 +216,7 @@ class _CachedExtraStudyPropertyUserAttrs(TestCase): warnings.simplefilter("ignore", category=ExperimentalWarning) def test_contains_failed_trials(self) -> None: - distributions = { + distributions: Dict[str, BaseDistribution] = { "x0": FloatDistribution(low=0, high=10), "x1": FloatDistribution(low=0, high=10), } @@ -252,12 +253,12 @@ class _CachedExtraStudyPropertyUserAttrs(TestCase): self.assertEqual(len(cached_extra_study_property.union_user_attrs), 3) def test_infer_sortable(self) -> None: - user_attrs_list = [ - {"a": 1, "b": 1, "c": 1, "d": "a"}, + user_attrs_list: List[Dict[str, Any]] = [ + {"a": 1, "b": 1, "c": 1, "d": "a", "e": 1}, {"a": 2, "b": "a", "c": "a", "d": "a"}, - {"a": 3, "b": None, "c": 3, "d": "a"}, + {"a": 3, "b": None, "c": 3, "d": "a", "e": 3}, ] - expected = {"a": True, "b": False, "c": False, "d": False} + expected = {"a": True, "b": False, "c": False, "d": False, "e": True} trials = [] for user_attrs in user_attrs_list: