From e40f410264b35c5fc4f343309fdbbeabb53529d6 Mon Sep 17 00:00:00 2001
From: moririn2528 <strangenoise1@gmail.com>
Date: Tue, 19 Sep 2023 13:38:42 +0900
Subject: [PATCH] fix by review

---
 optuna_dashboard/_serializer.py              | 12 ++++++------
 optuna_dashboard/ts/apiClient.ts             |  6 ++----
 optuna_dashboard/ts/components/AppDrawer.tsx |  4 ++--
 3 files changed, 10 insertions(+), 12 deletions(-)

diff --git a/optuna_dashboard/_serializer.py b/optuna_dashboard/_serializer.py
index 016b7fb8..e1840df9 100644
--- a/optuna_dashboard/_serializer.py
+++ b/optuna_dashboard/_serializer.py
@@ -165,13 +165,13 @@ def serialize_study_detail(
     form_widgets = get_form_widgets_json(system_attrs)
     if form_widgets:
         serialized["form_widgets"] = form_widgets
+    serialized["feedback_component_type"] = system_attrs.get(
+        _SYSTEM_ATTR_FEEDBACK_COMPONENT,
+        {
+            "output_type": "note",
+        },
+    )
     if serialized["is_preferential"]:
-        serialized["feedback_component_type"] = system_attrs.get(
-            _SYSTEM_ATTR_FEEDBACK_COMPONENT,
-            {
-                "output_type": "note",
-            },
-        )
         serialized["preference_history"] = serialize_preference_history(system_attrs)
         serialized["preferences"] = get_preferences(system_attrs)
         serialized["skipped_trials"] = skipped_trials
diff --git a/optuna_dashboard/ts/apiClient.ts b/optuna_dashboard/ts/apiClient.ts
index e552f773..60c461db 100644
--- a/optuna_dashboard/ts/apiClient.ts
+++ b/optuna_dashboard/ts/apiClient.ts
@@ -101,7 +101,7 @@ interface StudyDetailResponse {
   preferences?: [number, number][]
   preference_history?: PreferenceHistoryResponce[]
   plotly_graph_objects: PlotlyGraphObject[]
-  feedback_component_type?: FeedbackComponentType
+  feedback_component_type: FeedbackComponentType
   skipped_trials?: number[]
 }
 
@@ -138,9 +138,7 @@ export const getStudyDetailAPI = (
         objective_names: res.data.objective_names,
         form_widgets: res.data.form_widgets,
         is_preferential: res.data.is_preferential,
-        feedback_component_type: res.data.feedback_component_type ?? {
-          output_type: "note",
-        },
+        feedback_component_type: res.data.feedback_component_type,
         preferences: res.data.preferences,
         preference_history: res.data.preference_history?.map(
           convertPreferenceHistory
diff --git a/optuna_dashboard/ts/components/AppDrawer.tsx b/optuna_dashboard/ts/components/AppDrawer.tsx
index b9117707..8740c68a 100644
--- a/optuna_dashboard/ts/components/AppDrawer.tsx
+++ b/optuna_dashboard/ts/components/AppDrawer.tsx
@@ -287,7 +287,7 @@ export const AppDrawer: FC<{
                 <ListItemText primary="Trials (Table)" sx={styleListItemText} />
               </ListItemButton>
             </ListItem>
-            <ListItem key="note" disablePadding sx={styleListItem}>
+            <ListItem key="Note" disablePadding sx={styleListItem}>
               <ListItemButton
                 component={Link}
                 to={`${URL_PREFIX}/studies/${studyId}/note`}
@@ -297,7 +297,7 @@ export const AppDrawer: FC<{
                 <ListItemIcon sx={styleListItemIcon}>
                   <RateReviewIcon />
                 </ListItemIcon>
-                <ListItemText primary="note" sx={styleListItemText} />
+                <ListItemText primary="Note" sx={styleListItemText} />
               </ListItemButton>
             </ListItem>
           </List>