From f4bff0fcfd5ce0f4a22d8b3ec318555823377df8 Mon Sep 17 00:00:00 2001 From: c-bata Date: Mon, 26 Dec 2022 11:59:52 +0900 Subject: [PATCH] Use skip_table_creation when using Optuna v3 or later --- optuna_dashboard/_app.py | 2 ++ optuna_dashboard/_cli.py | 8 ++------ 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/optuna_dashboard/_app.py b/optuna_dashboard/_app.py index 94009dae..97be5221 100644 --- a/optuna_dashboard/_app.py +++ b/optuna_dashboard/_app.py @@ -406,6 +406,8 @@ def get_storage(storage: Union[str, BaseStorage]) -> BaseStorage: raise ValueError( "RedisStorage is unsupported from Optuna v3.1 or Optuna Dashboard v0.8.0" ) + elif version.parse(optuna_ver) >= version.Version("v3.0.0"): + return RDBStorage(storage, skip_compatibility_check=True, skip_table_creation=True) else: return RDBStorage(storage, skip_compatibility_check=True) return storage diff --git a/optuna_dashboard/_cli.py b/optuna_dashboard/_cli.py index 1b3d3fca..25d7ca4d 100644 --- a/optuna_dashboard/_cli.py +++ b/optuna_dashboard/_cli.py @@ -11,7 +11,7 @@ from optuna.storages import BaseStorage from optuna.storages import RDBStorage from . import __version__ -from ._app import create_app +from ._app import create_app, get_storage from ._sql_profiler import register_profiler_view @@ -97,11 +97,7 @@ def main() -> None: args = parser.parse_args() storage: BaseStorage - if args.storage.startswith("redis"): - raise ValueError("RedisStorage is unsupported from Optuna v3.1 or Optuna Dashboard v0.8.0") - else: - storage = RDBStorage(args.storage, skip_compatibility_check=True) - + storage = get_storage(args.storage) app = create_app(storage, debug=DEBUG) if DEBUG and isinstance(storage, RDBStorage):