From f5b3da3a4b9bb1c1af8a0a556c8dba67a360808c Mon Sep 17 00:00:00 2001
From: c-bata <contact@c-bata.link>
Date: Sun, 15 Jan 2023 12:36:55 +0900
Subject: [PATCH] Show message on drag over

---
 optuna_dashboard/ts/components/Note.tsx       | 63 ++++++++++++++-----
 .../ts/components/StudyDetailBeta.tsx         | 28 +++++++--
 optuna_dashboard/ts/components/TrialList.tsx  |  9 +++
 3 files changed, 79 insertions(+), 21 deletions(-)

diff --git a/optuna_dashboard/ts/components/Note.tsx b/optuna_dashboard/ts/components/Note.tsx
index 38d9c33d..c8e02c60 100644
--- a/optuna_dashboard/ts/components/Note.tsx
+++ b/optuna_dashboard/ts/components/Note.tsx
@@ -36,7 +36,6 @@ import LoadingButton from "@mui/lab/LoadingButton"
 import SaveIcon from "@mui/icons-material/Save"
 import CloseIcon from "@mui/icons-material/Close"
 import EditIcon from "@mui/icons-material/Edit"
-import Divider from "@mui/material/Divider"
 import { Theme } from "@mui/material/styles"
 import {
   CodeComponent,
@@ -497,6 +496,33 @@ const ArtifactUploader: FC<{
           overflow: "scroll",
         }}
       >
+        {dragOver && (
+          <Box
+            sx={{
+              width: "100%",
+              height: "100%",
+              position: "relative",
+              display: "flex",
+              flexDirection: "column",
+              justifyContent: "center",
+              alignItems: "center",
+              backgroundColor:
+                theme.palette.mode === "dark"
+                  ? "rgba(255, 255, 255, 0.3)"
+                  : "rgba(0,0,0,0.3)",
+            }}
+          >
+            <UploadFileIcon
+              sx={{ fontSize: 80, marginBottom: theme.spacing(2) }}
+            />
+            <Typography>Upload a New Image</Typography>
+            <Typography
+              sx={{ textAlign: "center", color: theme.palette.grey.A400 }}
+            >
+              Drag your file here.
+            </Typography>
+          </Box>
+        )}
         <ImageList cols={1} sx={{ margin: 0 }}>
           {artifacts
             .filter((a) => a.mimetype.startsWith("image"))
@@ -557,22 +583,27 @@ const NoteBase: FC<{
   const defaultBody = ""
   return (
     <Card sx={{ overflow: "scroll", ...cardSx }}>
-      <CardHeader
-        title="Note"
-        action={
-          <IconButton
-            onClick={() => {
-              setEditorMounted(true)
-            }}
-          >
-            <EditIcon />
-          </IconButton>
-        }
-        sx={{ paddingBottom: 0 }}
-      />
-      <CardContent sx={{ paddingTop: theme.spacing(1) }}>
-        <Divider />
+      <CardContent
+        sx={{
+          paddingTop: theme.spacing(1),
+          position: "relative",
+          minHeight: theme.spacing(7),
+        }}
+      >
         <MarkdownRenderer body={latestNote.body || defaultBody} />
+        <IconButton
+          sx={{
+            position: "absolute",
+            top: 0,
+            right: 0,
+            margin: theme.spacing(1),
+          }}
+          onClick={() => {
+            setEditorMounted(true)
+          }}
+        >
+          <EditIcon />
+        </IconButton>
       </CardContent>
       {editorMounted && (
         <MarkdownEditorModal
diff --git a/optuna_dashboard/ts/components/StudyDetailBeta.tsx b/optuna_dashboard/ts/components/StudyDetailBeta.tsx
index f7f49a31..c239acbd 100644
--- a/optuna_dashboard/ts/components/StudyDetailBeta.tsx
+++ b/optuna_dashboard/ts/components/StudyDetailBeta.tsx
@@ -126,11 +126,29 @@ export const StudyDetailBeta: FC<{
     content = <TrialList studyDetail={studyDetail} />
   } else if (page === "note" && studyDetail !== null) {
     content = (
-      <StudyNote
-        studyId={studyId}
-        latestNote={studyDetail.note}
-        cardSx={{ height: "90vh" }}
-      />
+      <Box
+        sx={{
+          height: `calc(100vh - ${theme.spacing(8)})`,
+          display: "flex",
+          flexDirection: "column",
+          padding: theme.spacing(2),
+        }}
+      >
+        <Typography
+          variant="h5"
+          sx={{
+            fontWeight: theme.typography.fontWeightBold,
+            margin: theme.spacing(2, 0),
+          }}
+        >
+          Note
+        </Typography>
+        <StudyNote
+          studyId={studyId}
+          latestNote={studyDetail.note}
+          cardSx={{ flexGrow: 1 }}
+        />
+      </Box>
     )
   }
 
diff --git a/optuna_dashboard/ts/components/TrialList.tsx b/optuna_dashboard/ts/components/TrialList.tsx
index 61cca6b1..d7c46c43 100644
--- a/optuna_dashboard/ts/components/TrialList.tsx
+++ b/optuna_dashboard/ts/components/TrialList.tsx
@@ -266,6 +266,15 @@ const TrialListDetail: FC<{
       >
         {info.map(([key, value]) => renderInfo(key, value))}
       </Box>
+      <Typography
+        variant="h5"
+        sx={{
+          fontWeight: theme.typography.fontWeightBold,
+          marginBottom: theme.spacing(1),
+        }}
+      >
+        Note
+      </Typography>
       <TrialNote
         studyId={trial.study_id}
         trialId={trial.trial_id}