wassname/phaser
1
0
Fork 0
mirror of https://github.com/wassname/phaser.git synced 2026-07-31 12:40:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fixed issue stopping SoundManager.volume from working correctly on a global volume basis (fix # 488)

Browse Source
This commit is contained in:
photonstorm
2014-02-26 14:40:55 +00:00
parent 4a97861ff8
commit d0fa50f014
3 changed files with 73 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/sound/SoundManager.js
+19 -7
View File
@@ -371,6 +371,12 @@ Phaser.SoundManager.prototype = {
},
/**
* Internal mute handler called automatically by the Sound.mute setter.
*
* @method Phaser.SoundManager#setMute
* @private
*/
setMute: function () {
if (this._muted)
@@ -397,6 +403,12 @@ Phaser.SoundManager.prototype = {
},
/**
* Internal mute handler called automatically by the Sound.mute setter.
*
* @method Phaser.SoundManager#unsetMute
* @private
*/
unsetMute: function () {
if (!this._muted || this._codeMuted)
@@ -487,21 +499,21 @@ Object.defineProperty(Phaser.SoundManager.prototype, "volume", {
set: function (value) {
value = this.game.math.clamp(value, 1, 0);
this._volume = value;
if (this.usingWebAudio)
{
this.masterGain.gain.value = value;
}
// Loop through the sound cache and change the volume of all html audio tags
for (var i = 0; i < this._sounds.length; i++)
else
{
if (this._sounds[i].usingAudioTag)
// Loop through the sound cache and change the volume of all html audio tags
for (var i = 0; i < this._sounds.length; i++)
{
this._sounds[i].volume = this._sounds[i].volume * value;
if (this._sounds[i].usingAudioTag)
{
this._sounds[i].volume = this._sounds[i].volume * value;
}
}
}