From 981169cacc5da17af8d796d94b747c17566ef0bc Mon Sep 17 00:00:00 2001 From: Ashraful Islam Date: Mon, 18 May 2020 09:53:02 -0400 Subject: [PATCH] add warning for shuffling in test/val (#1865) --- pytorch_lightning/trainer/data_loading.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pytorch_lightning/trainer/data_loading.py b/pytorch_lightning/trainer/data_loading.py index b84e2d27..fff67d10 100644 --- a/pytorch_lightning/trainer/data_loading.py +++ b/pytorch_lightning/trainer/data_loading.py @@ -214,7 +214,7 @@ class TrainerDataLoadingMixin(ABC): # shuffling in val and test set is bad practice for loader in dataloaders: if mode in ('val', 'test') and hasattr(loader, 'sampler') and isinstance(loader.sampler, RandomSampler): - raise MisconfigurationException( + rank_zero_warn( f'Your {mode}_dataloader has shuffle=True, it is best practice to turn' ' this off for validation and test dataloaders.')