diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index e9182fb2..71023d65 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -51,3 +51,7 @@ A lot of good work has already been done in project mechanics (requirements.txt, ## Coding Styleguide 1. Test the code with flake8. 2. Use f-strings. +3. run locally PEP8 fixes: + ``` + autopep8 -v -r --max-line-length 120 --in-place . + ``` \ No newline at end of file diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index a7967307..5312cf39 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -2,14 +2,16 @@ name: Bug report about: Create a report to help us improve title: '' -labels: bug +labels: bug, help wanted assignees: '' --- + ## 🐛 Bug diff --git a/.github/ISSUE_TEMPLATE/documentation.md b/.github/ISSUE_TEMPLATE/documentation.md index 1162def1..2b249089 100644 --- a/.github/ISSUE_TEMPLATE/documentation.md +++ b/.github/ISSUE_TEMPLATE/documentation.md @@ -2,7 +2,7 @@ name: Typos and doc fixes about: Typos and doc fixes title: '' -labels: typo +labels: typo, documentation assignees: '' --- diff --git a/pytorch_lightning/loggers/comet.py b/pytorch_lightning/loggers/comet.py index ce547ab6..06b27148 100644 --- a/pytorch_lightning/loggers/comet.py +++ b/pytorch_lightning/loggers/comet.py @@ -31,6 +31,7 @@ class CometLogger(LightningLoggerBase): r""" Log using `comet.ml `_. """ + def __init__(self, api_key=None, save_dir=None, workspace=None, rest_api_key=None, project_name=None, experiment_name=None, **kwargs): r""" diff --git a/pytorch_lightning/loggers/neptune.py b/pytorch_lightning/loggers/neptune.py index 6659bcff..e8a087a0 100644 --- a/pytorch_lightning/loggers/neptune.py +++ b/pytorch_lightning/loggers/neptune.py @@ -27,6 +27,7 @@ class NeptuneLogger(LightningLoggerBase): Neptune logger can be used in the online mode or offline (silent) mode. To log experiment data in online mode, NeptuneLogger requries an API key: """ + def __init__(self, api_key=None, project_name=None, offline_mode=False, experiment_name=None, upload_source_files=None, params=None, properties=None, tags=None, **kwargs): diff --git a/pytorch_lightning/trainer/trainer.py b/pytorch_lightning/trainer/trainer.py index fd29ccf6..c7da1111 100644 --- a/pytorch_lightning/trainer/trainer.py +++ b/pytorch_lightning/trainer/trainer.py @@ -862,7 +862,7 @@ class Trainer(TrainerIOMixin, # check if we should run validation during training self.disable_validation = ((self.num_val_batches == 0 or - not self.is_overriden('validation_step')) and + not self.is_overriden('validation_step')) and not self.fast_dev_run) # run tiny validation (if validation defined) diff --git a/tests/requirements.txt b/tests/requirements.txt index b2c3ca47..9b35ff7b 100644 --- a/tests/requirements.txt +++ b/tests/requirements.txt @@ -4,6 +4,7 @@ coverage codecov pytest>=3.0.5 pytest-cov +pytest-flake8 flake8 check-manifest test-tube>=0.7.5