From b84b02400a312240a6429c186cc63514eeb45a82 Mon Sep 17 00:00:00 2001 From: William Falcon Date: Fri, 15 May 2020 15:08:16 -0400 Subject: [PATCH] enable any dict and namespace in hparams (#1847) --- pytorch_lightning/trainer/training_io.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/pytorch_lightning/trainer/training_io.py b/pytorch_lightning/trainer/training_io.py index 947942ff..4f83949f 100644 --- a/pytorch_lightning/trainer/training_io.py +++ b/pytorch_lightning/trainer/training_io.py @@ -344,10 +344,11 @@ class TrainerIOMixin(ABC): if hasattr(model, "hparams") and model.hparams is not None: parsing.clean_namespace(model.hparams) - checkpoint['hparams_type'] = model.hparams.__class__.__name__ - if checkpoint['hparams_type'] == 'dict': + if isinstance(model.hparams, dict): + checkpoint['hparams_type'] = 'dict' checkpoint['hparams'] = model.hparams - elif checkpoint['hparams_type'] == 'Namespace': + elif isinstance(model.hparams, Namespace): + checkpoint['hparams_type'] = 'Namespace' checkpoint['hparams'] = vars(model.hparams) else: raise ValueError(