From f3d139e90f9212813c4f5e6de777bdef9dfe7635 Mon Sep 17 00:00:00 2001 From: Boris Dayma Date: Fri, 24 Apr 2020 09:29:24 -0500 Subject: [PATCH] fix(wandb): allow use of sweeps (#1512) * fix(wandb): allow use of sweeps overwrite run config parameters due to precision error fix #1290 * docs(wandb): update changelog * test(wandb): update config test Co-authored-by: William Falcon --- CHANGELOG.md | 2 ++ pytorch_lightning/loggers/wandb.py | 2 +- tests/loggers/test_wandb.py | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8d758c6d..0a507401 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -66,6 +66,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). - Added a missing call to the `on_before_zero_grad` model hook ([#1493](https://github.com/PyTorchLightning/pytorch-lightning/pull/1493)). +- Allow use of sweeps with WandbLogger ([#1512](https://github.com/PyTorchLightning/pytorch-lightning/pull/1512)) + - Fixed a bug that caused the `callbacks` Trainer argument to reference a global variable ([#1534](https://github.com/PyTorchLightning/pytorch-lightning/pull/1534)). - Fixed a bug that set all boolean CLI arguments from Trainer.add_argparse_args always to True ([#1570](https://github.com/PyTorchLightning/pytorch-lightning/issues/1570)) diff --git a/pytorch_lightning/loggers/wandb.py b/pytorch_lightning/loggers/wandb.py index 8d4bd0aa..3e844305 100644 --- a/pytorch_lightning/loggers/wandb.py +++ b/pytorch_lightning/loggers/wandb.py @@ -114,7 +114,7 @@ class WandbLogger(LightningLoggerBase): @rank_zero_only def log_hyperparams(self, params: Union[Dict[str, Any], Namespace]) -> None: params = self._convert_params(params) - self.experiment.config.update(params) + self.experiment.config.update(params, allow_val_change=True) @rank_zero_only def log_metrics(self, metrics: Dict[str, float], step: Optional[int] = None) -> None: diff --git a/tests/loggers/test_wandb.py b/tests/loggers/test_wandb.py index 87240ac3..d2ef6318 100644 --- a/tests/loggers/test_wandb.py +++ b/tests/loggers/test_wandb.py @@ -23,7 +23,7 @@ def test_wandb_logger(wandb): wandb.init().log.assert_called_once_with({'global_step': 3, 'acc': 1.0}) logger.log_hyperparams({'test': None}) - wandb.init().config.update.assert_called_once_with({'test': None}) + wandb.init().config.update.assert_called_once_with({'test': None}, allow_val_change=True) logger.watch('model', 'log', 10) wandb.init().watch.assert_called_once_with('model', log='log', log_freq=10)