Piotr Łusakowski
0cb6767465
Fix NeptuneLogger to work in ddp mode ( #1753 )
2020-05-10 13:19:18 -04:00
Jirka Borovec
134eb61e1a
Tests: refactor cleanup ( #1744 )
...
* wip
* cleaning
* optim imports
* -
* default hparams
* fix restore
* fix imports
2020-05-10 13:15:28 -04:00
Jirka Borovec
0cd5e64701
Tests: refactor loggers ( #1689 )
...
* refactor default model
* drop redundant seeds
* path
* refactor loggers tests
* imports
2020-05-04 07:13:52 -04:00
152a2eb30c
wandb logger 'global_step' affects other logger ( #1492 )
...
* Removed unnecessary 'global_step' from wandb logger.
* Fixed wrong step implementation in wandb and missing metric skipping in logger base.
* simplified metric check in base logger
* Added Fix Description in CHANGELOG.md
* Updated wandb logger tests.
* udpate test, step=3
* Moved Fix Description in CHANGELOG.md to unreleased.
* Update CHANGELOG.md
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com >
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
2020-05-02 08:50:47 -04:00
Jirka Borovec
f380027951
refactor default model ( #1652 )
...
* refactor default model
* drop redundant seeds
* formatting
* path
* formatting
* rename
2020-05-02 08:38:22 -04:00
Jirka Borovec
34bc149359
move unnecessary dict trainer_options ( #1469 )
...
* move unnecessary dict trainer_options
* fix tests
* fix tests
* formatting
* missing
2020-05-01 10:43:58 -04:00
William Falcon
e7ea564df2
pep8
2020-04-27 08:47:19 -04:00
William Falcon
5c0118fe9d
ddp pickle
2020-04-27 08:03:32 -04:00
Justus Schock
ccd49cfbc5
tests pep8
2020-04-27 09:53:59 +02:00
Justus Schock
335819e1b7
Update test_tensorboard.py
2020-04-27 09:52:31 +02:00
Justus Schock
312e394654
Update test_tensorboard.py
2020-04-27 09:50:01 +02:00
58a467dd68
model checkpint on rank_zero_only & global rank state ( #1408 )
...
* try delete in async or DDP us0-ecase
* changelog
* add model chekpoint rank
* simple delete
* flake8
* use global rank
* chnagelog
* fix review
* fix import
* proposal
* proposal
* proposal
* improve proposal (fix problems with method call self)
* cleaning
Co-authored-by: Adrian Wälchli <adrian.waelchli@students.unibe.ch >
Co-authored-by: William Falcon <waf2107@columbia.edu >
2020-04-24 17:21:00 -04:00
Boris Dayma and William Falcon
f3d139e90f
fix(wandb): allow use of sweeps ( #1512 )
...
* fix(wandb): allow use of sweeps
overwrite run config parameters due to precision error
fix #1290
* docs(wandb): update changelog
* test(wandb): update config test
Co-authored-by: William Falcon <waf2107@columbia.edu >
2020-04-24 10:29:24 -04:00
Guy Davidson
fe2b6666e0
Fixing a small issue in trainer logging ( #1563 )
...
* The epoch was being logged to metrics, which isn't read, rather than to current_metrics.
* Updated the tests to account for the epoch arriving at the logger.
2020-04-23 17:52:41 -04:00
Jirka Borovec
c1c6e3b6c9
default test logger ( #1478 )
...
* default test logger
* fix tests
* spawn
* try
* simplify tests
* simplify tests
* formatting
* loggers
* loggers
* revert to TestTube
* default
* default
* wraps
* world size
* optim imports
2020-04-21 20:33:10 -04:00
William Falcon and J. Borovec
3431c62d41
Remove error when test dataloader used in test ( #1495 )
...
* remove error when test dataloader used in test
* remove error when test dataloader used in test
* remove error when test dataloader used in test
* remove error when test dataloader used in test
* remove error when test dataloader used in test
* remove error when test dataloader used in test
* fix lost model reference
* remove error when test dataloader used in test
* fix lost model reference
* moved optimizer types
* moved optimizer types
* moved optimizer types
* moved optimizer types
* moved optimizer types
* moved optimizer types
* moved optimizer types
* moved optimizer types
* added tests for warning
* fix lost model reference
* fix lost model reference
* added tests for warning
* added tests for warning
* refactoring
* refactoring
* fix imports
* refactoring
* fix imports
* refactoring
* fix tests
* fix mnist
* flake8
* review
Co-authored-by: J. Borovec <jirka.borovec@seznam.cz >
2020-04-15 22:16:40 -04:00
Jirka Borovec
8322f1b039
neptune online ( #1499 )
2020-04-15 11:14:29 -04:00
Jirka Borovec
b3fe17ddeb
fix flushing loggers ( #1459 )
...
* flushing loggers
* flushing loggers
* flushing loggers
* flushing loggers
* changelog
* typo
* fix trains
* optimize imports
* add logger test all
* add logger test pickle
* flake8
* fix benchmark
* hanging loggers
* try
* del
* all
* cleaning
2020-04-14 20:32:33 -04:00
William Falcon
b78c3d4da8
Fix weights path ( #1445 )
...
* renamed default path to actual root_dir
* added default weights path
* added default weights path
* added default weights path
2020-04-10 12:02:59 -04:00
ddbf7de6dc
Added accumulation of loggers' metrics for the same steps ( #1278 )
...
* `add_argparse_args` method fixed (argument types added)
* autopep8 fixes
* --gpus=0 removed from test (for ci tests)
* Update pytorch_lightning/trainer/trainer.py
Co-Authored-By: Joe Davison <joe@huggingface.co >
* test_with_accumulate_grad_batches added
* agg_and_log_metrics logic added to the base logger class
* small format fix
* agg metrics strategies removed (not to complicate stuff)
* agg metrics: handle zero step
* autopep8
* changelog upd
* flake fix
* metrics aggregators factored out, metrics_agg.py added + tests
* metrics agg default value added
* Update pytorch_lightning/loggers/metrics_agg.py
Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com >
* metrics aggregators factored out, metrics_agg.py added + tests
* metrics agg default value added
* Update pytorch_lightning/loggers/metrics_agg.py
Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com >
* remove .item which causes sync issues (#1254 )
* remove .item which causes sync issues
* fixed gradient acc sched
* fixed gradient acc sched
* test_metrics_agg.py removed (all tested in doctrings), agg metrics refactored
* test_metrics_agg.py removed (all tested in doctrings), agg metrics refactored
* autopep8
* loggers base.py types fixed
* test
* test
* metrics aggregation for loggers: each key now has a specific function (or default one)
* metrics aggregation for loggers: each key now has a specific function (or default one)
* docstrings upd
* manual typehints removed from docstrings
* batch_size decreased for test `test_with_accumulate_grad_batches`
* extend running accum
* refactor
* fix tests
* fix tests
* allowed_types generator scoped
* trainer.py distutils was imported twice, fixed
* TensorRunningAccum refactored
* TensorRunningAccum added to change log (Changed)
* change log pull link added
Co-authored-by: Joe Davison <joe@huggingface.co >
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
Co-authored-by: William Falcon <waf2107@columbia.edu >
Co-authored-by: J. Borovec <jirka.borovec@seznam.cz >
2020-04-08 08:35:47 -04:00
3c5530c29d
Wandb bug/wandb multi ( #1360 )
...
* Allow reinits in sub procs
* Dont create an experiment on pickle, name, or project
* Comments consistency
* Fix test
* Apply suggestions from code review
Co-authored-by: Chris Van Pelt <vanpelt@gmail.com >
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
2020-04-03 15:03:00 -04:00
dd5a05926c
Borisdayma: fix(wandb) - fix watch method ( #1361 )
...
* fix(wandb): fix watch method
* rebased
* Apply suggestions from code review
Co-authored-by: Boris Dayma <boris.dayma@gmail.com >
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
2020-04-03 15:02:38 -04:00
Jean-Baptiste SCHIRATTI and Jean-Baptiste SCHIRATTI
868b172f05
Make training_epoch_end behave like validation_epoch_end ( #1357 )
...
* Make training_epoch_end behave like validation_epoch_end + minor fixes in docstrings.
* Minor fixes (Borda's comments).
* Detach tensors in batch_output (to avoid possible memory leak) + doc fix.
Co-authored-by: Jean-Baptiste SCHIRATTI <jean-baptisteschiratti@MacBook-Pro-de-Jean-Baptiste.local >
2020-04-03 14:43:26 +02:00
Jirka Borovec
6ddb03922a
Profiler summary ( #1259 )
...
* refactor and add types
* add Prorfiler summary
* fix imports
* Revert "refactor and add types"
This reverts commit b4c552fa
* changelog
* revert rename
* fix test
* mute verbose
2020-03-31 08:57:48 -04:00
a707d4bea1
Replace Wandb callback's finalize with no-op ( #1193 )
...
* Replace Wandb callback's finalize with no-op
* Update pytorch_lightning/loggers/wandb.py
* Update wandb.py
* remove wandb logger's finalize and update tests
* update changelog
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
Co-authored-by: William Falcon <waf2107@columbia.edu >
2020-03-30 18:45:06 -04:00
Jirka Borovec
45d671a4a8
CI: split tests-examples ( #990 )
...
* CI: split tests-examples
* tests without template
* comment depends
* CircleCI typo
* add doctest
* update test req.
* CI tests
* setup macOS
* longer train
* lover pred acc
* fix model
* rename default model
* lower tests acc
* typo
* imports
* fix test optimizer
* update calls
* fix Win
* lower Drone image
* fix call
* pytorch image
* fix test
* add dev image
* add dev image
* update image
* drone volume
* lint
* update test notes
* rename tests/models >> tests/base
* group models
* conftest
* optim imports
* typos
* fix import
* fix tests
* install AMP
* tests
* fix import
2020-03-25 07:46:27 -04:00
Jirka Borovec and Nic Eggert
3be81cb54e
test deprecated - model ( #1074 )
...
* pylint
* model API
* update test
* formatting
* disable logger
* fix checking overwrite
* fix test
* typo
* deprecated model
* fix for DDP
* drop Flake8 in GH actions
* Update pytorch_lightning/trainer/evaluation_loop.py
* fix imports
Co-authored-by: Nic Eggert <nic@eggert.io >
2020-03-20 20:51:14 +01:00
So Uchida and Jirka Borovec
01b8991c5a
Support hierarchical dict ( #1152 )
...
* Add support for hierarchical dict
* Support nested Namespace
* Add docstring
* Migrate hparam flattening to each logger
* Modify URLs in CHANGELOG
* typo
* Simplify the conditional branch about Namespace
Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com >
* Update CHANGELOG.md
Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com >
* added examples section to docstring
* renamed _dict -> input_dict
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
2020-03-19 09:15:47 -04:00
22a7264e9a
improve partial Codecov ( #1172 )
...
* ignore in setup
* show report
* abs imports
* abstract pass
* cover loggers
* doctest trains
* locals
* pass
* revert tensorboard
* use tensorboardX
* revert tensorboardX
* fix trains
* Add TrainsLogger.set_credentials (#1179 )
* Add TrainsLogger.set_credentials to control trains server configuration and authentication from code. Sync trains package version.
Fix CI Trains tests
* Add global TrainsLogger set_bypass_mode (#1187 )
* Add global TrainsLogger set_bypass_mode skips all external communication
Co-authored-by: bmartinn <>
* rm some no-cov
Co-authored-by: Martin.B <51887611+bmartinn@users.noreply.github.com >
2020-03-19 09:14:29 -04:00
Jakub
3ad6169f18
Neptune Logger Improvements ( #1084 )
...
* removed project and experiment from getstate
* added tests for closing experiment, updated token in example to user neptuner
* updated teoken
* Update neptune.py
added a link to example experiment
* added exmaple experiment link
* dropped duplication
* flake fixes
* merged with master, added changes information to CHANGELOG
2020-03-14 13:02:40 -04:00
c0bedd2587
Add TRAINS experiment manager support ( #1122 )
...
* Add allegro.ai TRAINS experiment manager support
* improve docstring and type hinting, fix the bug in log_metrics, add support torch.Tensor to input into log_image
* complete missing docstring of constructor's arguments
* fix docs
* pep8
* pep8
* remove redundant typing
use logging
fix typing and pep8
* remove deprecated interface
* add TrainsLogger test
* add TrainsLogger PR in CHANGELOG
* add id/name property documentation
* change logging as log
Co-authored-by: bmartinn <>
Co-authored-by: Sou Uchida <s.aiueo32@gmail.com >
2020-03-14 13:02:14 -04:00
da61398835
Add Support for Non-primitive types in TensorboardLogger ( #1130 )
...
* Added support for non-primitive types to tensorboard logger
* added EOF newline
* PEP8
* Updated CHANGELOG for PR #1130 . Moved _sanitize_params to base logger. Cleaned up _sanitize_params
* Updated CHANGELOG for PR #1130 . Moved _sanitize_params to base logger. Cleaned up _sanitize_params
* changed convert_params to static method
* PEP8
* Cleanup Doctest for _sanitize_params
Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com >
* Removed OrderedDict import
* Updated import order to conventions
Co-authored-by: Manbir Gulati <manbirgulati@Manbirs-MBP.hsd1.md.comcast.net >
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
2020-03-14 13:02:05 -04:00
Jirka Borovec
514d182b7f
cleaning imports ( #1032 )
2020-03-12 12:41:37 -04:00
Jirka Borovec and William Falcon
e586ed4767
hparams as dict [blocked by 1041] ( #1029 )
...
* hparams as dict
* hparams as dict
* fixing
* fixing
* fixing
* fixing
* typing
* typing
* chnagelog
* update set hparams
* use setter
* simplify
* chnagelog
* imports
* pylint
* typing
* Update training_io.py
* Update training_io.py
* Update lightning.py
* Update test_trainer.py
* Update __init__.py
* Update base.py
* Update utils.py
* Update test_trainer.py
* Update training_io.py
* Update test_trainer.py
* Update test_trainer.py
* Update test_trainer.py
* Update test_trainer.py
* Update callback_config.py
* Update callback_config.py
* Update test_trainer.py
Co-authored-by: William Falcon <waf2107@columbia.edu >
2020-03-04 09:33:39 -05:00
Ethan Harris
f862d9f691
Logger tests and fixes ( #1009 )
...
* Refactor logger tests
* Update and add tests for wandb logger
* Update and add tests for logger bases
* Update and add tests for mlflow logger
* Improve coverage
* Updates
* Update CHANGELOG
* Updates
* Fix style
* Fix style
* Updates
2020-03-02 20:49:14 -05:00
Piotr Łusakowski