William Falcon and Jirka
10b16dbfab
made ddp the default if no backend specified with multiple GPUs ( #1789 )
...
* made ddp the default if no backend specified with multiple GPUs
* fix
* spawn
Co-authored-by: Jirka <jirka.borovec@seznam.cz >
2020-05-12 06:54:23 -04:00
Kevin Chen
de1fdd8d3b
Removed test_dataloader call in check_testing_model_configuration ( #1670 )
...
* Removed test_dataloader call
* Check if test_dataloader is actually overriden
* Fixed method spelling
* Replaced lambdas
* Replaced None with super method
* Fixed testpass
2020-05-12 00:08:07 -04:00
William Falcon
5bb6b41b78
dataloaders with fast_dev_run ( #1787 )
...
* dataloaders with fast_dev_run
* dataloaders with fast_dev_run
* dataloaders with fast_dev_run
* fix
* pep 8
2020-05-11 23:32:44 -04:00
Jirka Borovec and Adrian Wälchli
9d2df24d6b
RC & Docs/changelog ( #1776 )
...
* missing
* RC
* tol
* Apply suggestions from code review
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com >
* test
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com >
2020-05-11 21:57:53 -04:00
Rohit Gupta
d962ab5d89
Fix lr key name in case of param groups ( #1719 )
...
* Fix lr key name in case of param groups
* Add tests
* Update test and added configure_optimizers__param_groups
* Update CHANGELOG
2020-05-10 17:05:34 -04:00
Piotr Łusakowski
0cb6767465
Fix NeptuneLogger to work in ddp mode ( #1753 )
2020-05-10 13:19:18 -04:00
Jirka Borovec
134eb61e1a
Tests: refactor cleanup ( #1744 )
...
* wip
* cleaning
* optim imports
* -
* default hparams
* fix restore
* fix imports
2020-05-10 13:15:28 -04:00
4970927ec8
Feature: auto scale batch size ( #1638 )
...
* auto batch finder
* fix styling
* add description
* add different modes
* fix copy paste error
* better organised code
* fix styling
* add tests
* fix
* fix
* add some documentation
* added CHANGELOG.md
* some documentation
* update based on review
* Update trainer.py
* Update docs/source/training_tricks.rst
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com >
* Update tests/trainer/test_trainer_tricks.py
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
* Update tests/trainer/test_trainer_tricks.py
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
* Apply suggestions from code review
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com >
* use EvalModelTemplate
* param tests
* rename
* wrap params
* rename function
* rename
* rename param
* fix
* abs
* rename
* refactor code
* add docs
* try
* arg
* loop
* exept
* loop
* drop bool
* docs
* docs
* added check and test for passing dataloader to fit
* styling fix
* update based on review
Co-authored-by: Nicki Skafte <nugginea@gmail.com >
Co-authored-by: William Falcon <waf2107@columbia.edu >
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com >
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
Co-authored-by: Jirka <jirka.borovec@seznam.cz >
2020-05-09 08:28:36 -04:00
Adrian Wälchli and Jirka
25bbd059df
Also update progress_bar in training_epoch_end ( #1724 )
...
* update prog. bar metrics on train epoch end
* changelog
* wip test
* more thorough testing
* comments
* update docs
* move test
Co-authored-by: Jirka <jirka.borovec@seznam.cz >
2020-05-08 23:31:56 -04:00
Shunta Komatsu
f656882942
Fix typo ( #1750 )
2020-05-07 09:25:54 -04:00
Peter Yu
851866333c
Attach version_ to checkpoint path only if version is int ( #1748 )
2020-05-06 12:38:32 -04:00
Jeremy Jordan
fc7f5919b5
improve pickle tests for callbacks ( #1717 )
...
* improve pickle tests for callbacks
* set mode dict as a class attr
2020-05-05 14:08:54 -04:00
Adrian Wälchli
2b03d34931
complete test ( #1705 )
2020-05-05 14:08:15 -04:00
Jirka Borovec and William Falcon
2a2f303ae9
Tests: refactor trainer dataloaders ( #1690 )
...
* refactor default model
* drop redundant seeds
* refactor dataloaders tests
* fix multiple
* fix conf
* flake8
* Apply suggestions from code review
Co-authored-by: William Falcon <waf2107@columbia.edu >
Co-authored-by: William Falcon <waf2107@columbia.edu >
2020-05-05 12:31:15 -04:00
Jirka Borovec
043ae697c2
Tests: refactor callbacks ( #1688 )
...
* refactor default model
* drop redundant seeds
* path
* refactor callback tests
* update
* fix sch
* wip
* fix return
* review
2020-05-04 16:52:22 -04:00
Jirka Borovec
6d58fb1353
Tests: refactor trainer ( #1728 )
...
* lr
* optim
* wip
* wip
* fix mean
* flake8
2020-05-04 16:51:39 -04:00
Nicki Skafte and Nicki Skafte
e865b046b1
Bugfix/lr finder ( #1676 )
...
* fix early stopping bug
* allow val dataloader
* update CHANGELOG.md
* fix early stopping bug
* allow val dataloader
* update CHANGELOG.md
Co-authored-by: Nicki Skafte <nugginea@gmail.com >
2020-05-04 11:38:51 -04:00
Jirka Borovec
1077159834
Tests: refactor models ( #1691 )
...
* refactor default model
* drop redundant seeds
* drop redundant seeds
* refactor models tests
* refactor models tests
* imports
* fix conf
* Apply suggestions from code review
2020-05-04 11:38:08 -04:00
Adrian Wälchli
d28b145393
Update type hints for multiple dataloaders in .fit() and .test() ( #1723 )
...
* update typehints
* change log
2020-05-04 08:24:34 -04:00
Jirka Borovec
0cd5e64701
Tests: refactor loggers ( #1689 )
...
* refactor default model
* drop redundant seeds
* path
* refactor loggers tests
* imports
2020-05-04 07:13:52 -04:00
Jirka Borovec
595ec65796
refactor trainer checks ( #1651 )
...
* refactor trainer checks
* opt
* none
* Apply suggestions from code review
* imports
* fix tensors
2020-05-04 01:25:48 -04:00
Adrian Wälchli and J. Borovec
e6b34ef90d
[WIP] Reduction when batch size < num gpus ( #1609 )
...
* reduce if <= num_gpus
* add test with explanation
* chlog
* fix changelog
Co-authored-by: J. Borovec <jirka.borovec@seznam.cz >
2020-05-02 11:01:44 -04:00
152a2eb30c
wandb logger 'global_step' affects other logger ( #1492 )
...
* Removed unnecessary 'global_step' from wandb logger.
* Fixed wrong step implementation in wandb and missing metric skipping in logger base.
* simplified metric check in base logger
* Added Fix Description in CHANGELOG.md
* Updated wandb logger tests.
* udpate test, step=3
* Moved Fix Description in CHANGELOG.md to unreleased.
* Update CHANGELOG.md
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com >
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
2020-05-02 08:50:47 -04:00
Jirka Borovec
f380027951
refactor default model ( #1652 )
...
* refactor default model
* drop redundant seeds
* formatting
* path
* formatting
* rename
2020-05-02 08:38:22 -04:00
Travis Addair and Jirka
2950f66983
Fix Horovod distributed backend to set the root_gpu property ( #1669 )
...
* params
* drop acc
* Fix Horovod distributed backend to set the root_gpu
* Fixed test
* Fixed tests
* Fixed lint
* Set root_gpu during initialization
* chlog
Co-authored-by: Jirka <jirka.borovec@seznam.cz >
2020-05-01 14:13:35 -04:00
Jirka Borovec
34bc149359
move unnecessary dict trainer_options ( #1469 )
...
* move unnecessary dict trainer_options
* fix tests
* fix tests
* formatting
* missing
2020-05-01 10:43:58 -04:00
Jirka Borovec
97c7b6b314
fixing LBFGS test ( #1678 )
...
* params
* drop acc
* acc
2020-05-01 10:41:15 -04:00
142bc0230e
Learning rate log callback ( #1498 )
...
* base implementation
* docs + implementation
* fix styling
* add lr string
* renaming
* CHANGELOG.md
* add tests
* Apply suggestions from code review
Co-Authored-By: Adrian Wälchli <aedu.waelchli@gmail.com >
* Apply suggestions from code review
* Update pytorch_lightning/callbacks/lr_logger.py
* Update pytorch_lightning/callbacks/lr_logger.py
* add test for naming
* base implementation
* docs + implementation
* fix styling
* add lr string
* renaming
* CHANGELOG.md
* add tests
* Apply suggestions from code review
Co-Authored-By: Adrian Wälchli <aedu.waelchli@gmail.com >
* Apply suggestions from code review
* Update pytorch_lightning/callbacks/lr_logger.py
* Update pytorch_lightning/callbacks/lr_logger.py
* add test for naming
* Update pytorch_lightning/callbacks/lr_logger.py
Co-Authored-By: Adrian Wälchli <aedu.waelchli@gmail.com >
* suggestions from code review
* fix styling
* rebase
* fix tests
Co-authored-by: Nicki Skafte <nugginea@gmail.com >
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com >
2020-04-30 08:06:41 -04:00
Nathan Breitsch
3eac6cfd4f
Don't convert namedtuple to tuple ( #1589 )
...
* Don't convert namedtuple to tuple
* Test namedtuples sent to device correctly
2020-04-30 08:04:50 -04:00
Peter Yu
8d564b5e38
call on_load_checkpoint() when resuming from checkpoint ( #1666 )
2020-04-30 07:57:24 -04:00
Peter Yu and mergify[bot]
42d5cfc3b0
None check for filepath in ModelCheckpoint ( #1654 )
...
Check if the optional filepath is None before checking if it exists
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-04-29 16:36:28 +00:00
William Falcon
e7ea564df2
pep8
2020-04-27 08:47:19 -04:00
William Falcon
710dbf5a12
ddp pickle
2020-04-27 08:04:02 -04:00
William Falcon
a3cebb4469
ddp pickle
2020-04-27 08:04:02 -04:00
William Falcon
5c0118fe9d
ddp pickle
2020-04-27 08:03:32 -04:00
William Falcon
4c4d0e6bc6
Merge pull request #1635 from PyTorchLightning/pkl
...
Fixes CPU DDP breaking change and DDP change
2020-04-27 07:42:42 -04:00
William Falcon
b993a3ed39
ddp pickle
2020-04-27 07:21:58 -04:00
Justus Schock
ccd49cfbc5
tests pep8
2020-04-27 09:53:59 +02:00
Justus Schock
335819e1b7
Update test_tensorboard.py
2020-04-27 09:52:31 +02:00
Justus Schock
312e394654
Update test_tensorboard.py
2020-04-27 09:50:01 +02:00
William Falcon
e7a0d98277
fix hparams issue
2020-04-26 17:34:33 -04:00
William Falcon
d40b4c8f80
fix hparams issue
2020-04-26 17:30:50 -04:00
William Falcon and J. Borovec
b620d86c54
diable val and test shuffling ( #1600 )
...
* diable val and test shuffling
* diable val and test shuffling
* diable val and test shuffling
* diable val and test shuffling
* log
* condition
* shuffle
* refactor
Co-authored-by: J. Borovec <jirka.borovec@seznam.cz >
2020-04-25 16:45:20 -04:00
58a467dd68
model checkpint on rank_zero_only & global rank state ( #1408 )
...
* try delete in async or DDP us0-ecase
* changelog
* add model chekpoint rank
* simple delete
* flake8
* use global rank
* chnagelog
* fix review
* fix import
* proposal
* proposal
* proposal
* improve proposal (fix problems with method call self)
* cleaning
Co-authored-by: Adrian Wälchli <adrian.waelchli@students.unibe.ch >
Co-authored-by: William Falcon <waf2107@columbia.edu >
2020-04-24 17:21:00 -04:00
Jirka Borovec
570b2c7aeb
fix depreated call ( #1596 )
...
* fix parity
* update deprecated call
2020-04-24 14:45:43 -04:00
Boris Dayma and William Falcon
f3d139e90f
fix(wandb): allow use of sweeps ( #1512 )
...
* fix(wandb): allow use of sweeps
overwrite run config parameters due to precision error
fix #1290
* docs(wandb): update changelog
* test(wandb): update config test
Co-authored-by: William Falcon <waf2107@columbia.edu >
2020-04-24 10:29:24 -04:00
William Falcon
890458fdbd
Fixes automatic parser bug ( #1585 )
...
* fixes gpu parsing
* fixes gpu parsing
2020-04-23 21:00:41 -04:00
3e8f2d99a9
Progress bar callback ( #1450 )
...
* squash and rebase
sanity check hooks
sanity check callback hook finish
moved core progress bar functionality into callback
wip
remove duplicate merge
clean up
imports
docs
sanity check progress bar main
sanity
move callback calls
init progrss bar callback
configuration and docs
changelog
rate decorator
pass process_position
disable on rank > 0
position index
is_enabled
remove decorator
refactor init tqdm bars
callback method ordering
cannot reset when disabled
sequence -> list
default values
fix has no attr _time()
move on_val_end to proper place
fix the pickle issue
update warning
properties
check for None
remove old comment
switch order
pull out non-tqdm functionality into base class
documentation for the base class
docs
fix refresh rate issue in validation
restrict type hint of trainer arg
more docs
update trainer docs
rst docs
fix lines too long
fix test
add missing type hints
fix typo
move docstring to __init__ solves doctest failures
remove doctest :(( can't fix the pickle error
fix example
simplify by saving trainer reference
fix docs errors
move docstring
initial value
multiple val checks per epoch
simpler handling of inf dataset sizes
update inf docs
renamed training_tqdm_dict
rename get_tqdm_dict
rename occurences of tqdm
update changelog
fix doctest
fix formatting errors
added callback tests
progress bar on off test
more tests for progress bar
weird test fix?
add ignored property
disable default progress bar in LR finder
change enable/disable behavior
trying doctest in CI again
undo doctest pickle error
undo doctest pickle error :((
remove progress_bar_callback Trainer arg and fix tests
restore progress bar after auto lr find
update docs
fix rebase
fix wrong negation
* fix fast dev run total
* more thorough testing
* remove old args
* fix merge
* fix merge
* separate tests
* type hint total batches
* reduce if
Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com >
* is_disabled
Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com >
* is_enabled
Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com >
* rename enabled/disabled
* move deprecated api
* remove duplicated test from merge
* fix rename is_disabled
* newline
* test also testprogress for fast dev run
Co-authored-by: J. Borovec <jirka.borovec@seznam.cz >
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
2020-04-23 20:46:18 -04:00
Guy Davidson
fe2b6666e0
Fixing a small issue in trainer logging ( #1563 )
...
* The epoch was being logged to metrics, which isn't read, rather than to current_metrics.
* Updated the tests to account for the epoch arriving at the logger.
2020-04-23 17:52:41 -04:00
Jirka Borovec
7989ca844c
test deprecation warnings ( #1470 )
...
* check deprecation warnings
* extend warning test
* try
* unimport modules
* update
2020-04-23 17:34:47 -04:00
