Rohit Gupta
d962ab5d89
Fix lr key name in case of param groups ( #1719 )
...
* Fix lr key name in case of param groups
* Add tests
* Update test and added configure_optimizers__param_groups
* Update CHANGELOG
2020-05-10 17:05:34 -04:00
Piotr Łusakowski
0cb6767465
Fix NeptuneLogger to work in ddp mode ( #1753 )
2020-05-10 13:19:18 -04:00
Alexander Kreuzer and Alexander Kreuzer
ee17c7c9c8
Fixed error message and test docstring ( #1698 )
...
training_dataloader -> train_dataloader
Co-authored-by: Alexander Kreuzer <alexander.kreuzer@sap.com >
2020-05-10 13:16:16 -04:00
Anthony Bisulco
76af84718a
Group argument wandb ( #1760 )
...
* group argument wandb
* formatting fix
2020-05-10 13:15:51 -04:00
4970927ec8
Feature: auto scale batch size ( #1638 )
...
* auto batch finder
* fix styling
* add description
* add different modes
* fix copy paste error
* better organised code
* fix styling
* add tests
* fix
* fix
* add some documentation
* added CHANGELOG.md
* some documentation
* update based on review
* Update trainer.py
* Update docs/source/training_tricks.rst
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com >
* Update tests/trainer/test_trainer_tricks.py
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
* Update tests/trainer/test_trainer_tricks.py
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
* Apply suggestions from code review
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com >
* use EvalModelTemplate
* param tests
* rename
* wrap params
* rename function
* rename
* rename param
* fix
* abs
* rename
* refactor code
* add docs
* try
* arg
* loop
* exept
* loop
* drop bool
* docs
* docs
* added check and test for passing dataloader to fit
* styling fix
* update based on review
Co-authored-by: Nicki Skafte <nugginea@gmail.com >
Co-authored-by: William Falcon <waf2107@columbia.edu >
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com >
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
Co-authored-by: Jirka <jirka.borovec@seznam.cz >
2020-05-09 08:28:36 -04:00
Adrian Wälchli and Jirka
25bbd059df
Also update progress_bar in training_epoch_end ( #1724 )
...
* update prog. bar metrics on train epoch end
* changelog
* wip test
* more thorough testing
* comments
* update docs
* move test
Co-authored-by: Jirka <jirka.borovec@seznam.cz >
2020-05-08 23:31:56 -04:00
Yuri Brovman and ybrovman
3a642601e8
added warning for None dataloader ( #1745 )
...
* added warning for None dataloader
* fixed variable style
* updated warning message
* remove unused import
Co-authored-by: ybrovman <ybrovman@ebay.com >
2020-05-07 09:26:41 -04:00
Shunta Komatsu
f656882942
Fix typo ( #1750 )
2020-05-07 09:25:54 -04:00
Pavel Grunt
b9364f96b1
lr_finder: Fix typo in docstring ( #1746 )
2020-05-06 12:39:22 -04:00
Peter Yu
851866333c
Attach version_ to checkpoint path only if version is int ( #1748 )
2020-05-06 12:38:32 -04:00
Yuri Brovman and ybrovman
35bbe178bd
fix _reset_eval_dataloader() for IterableDataset ( #1560 )
...
* removed if dl from _reset_eval_dataloader()
* changed to if dl != None to be more safe
* hints from pep8speaks
Co-authored-by: ybrovman <ybrovman@ebay.com >
2020-05-05 14:09:48 -04:00
Jeremy Jordan
fc7f5919b5
improve pickle tests for callbacks ( #1717 )
...
* improve pickle tests for callbacks
* set mode dict as a class attr
2020-05-05 14:08:54 -04:00
Tian Wang
d6a0375974
Fixing logic ( #1734 )
2020-05-05 14:07:26 -04:00
Jirka Borovec and William Falcon
2a2f303ae9
Tests: refactor trainer dataloaders ( #1690 )
...
* refactor default model
* drop redundant seeds
* refactor dataloaders tests
* fix multiple
* fix conf
* flake8
* Apply suggestions from code review
Co-authored-by: William Falcon <waf2107@columbia.edu >
Co-authored-by: William Falcon <waf2107@columbia.edu >
2020-05-05 12:31:15 -04:00
Travis Addair
f90afa29b8
Fix disabling progress bar on non-zero ranks using Horovod backend ( #1709 )
...
* Fix Horovod backend to disable progress bar on all ranks except 0
* Add join barriers
* Added changelog
* Make protected and add verbosity
* Refactor to disable progress bar callback in train
* Removed vebose setting
* Add cache check for Horovod
* Test run again
* Updated comment
* Always skip cache for Horovod
* Only reinstall when necessary
* Added separate step
* Fixed spacing
* Skip Python 3.8
2020-05-04 13:02:57 -04:00
Nicki Skafte and Nicki Skafte
e865b046b1
Bugfix/lr finder ( #1676 )
...
* fix early stopping bug
* allow val dataloader
* update CHANGELOG.md
* fix early stopping bug
* allow val dataloader
* update CHANGELOG.md
Co-authored-by: Nicki Skafte <nugginea@gmail.com >
2020-05-04 11:38:51 -04:00
Jirka Borovec
1077159834
Tests: refactor models ( #1691 )
...
* refactor default model
* drop redundant seeds
* drop redundant seeds
* refactor models tests
* refactor models tests
* imports
* fix conf
* Apply suggestions from code review
2020-05-04 11:38:08 -04:00
Adrian Wälchli
d28b145393
Update type hints for multiple dataloaders in .fit() and .test() ( #1723 )
...
* update typehints
* change log
2020-05-04 08:24:34 -04:00
Adrian Wälchli and J. Borovec
e6b34ef90d
[WIP] Reduction when batch size < num gpus ( #1609 )
...
* reduce if <= num_gpus
* add test with explanation
* chlog
* fix changelog
Co-authored-by: J. Borovec <jirka.borovec@seznam.cz >
2020-05-02 11:01:44 -04:00
Adrian Wälchli and Jirka Borovec
d06d5e68b6
Fix typo in progress bar docs ( #1680 )
...
* fix typo
* Typo
* typo Borda
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
2020-05-02 09:08:21 -04:00
152a2eb30c
wandb logger 'global_step' affects other logger ( #1492 )
...
* Removed unnecessary 'global_step' from wandb logger.
* Fixed wrong step implementation in wandb and missing metric skipping in logger base.
* simplified metric check in base logger
* Added Fix Description in CHANGELOG.md
* Updated wandb logger tests.
* udpate test, step=3
* Moved Fix Description in CHANGELOG.md to unreleased.
* Update CHANGELOG.md
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com >
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
2020-05-02 08:50:47 -04:00
Jacob Zhong
4dc77b5a1a
Change lightning module params to dict when loading ( #1639 )
...
* change module params to dict
* tiny change
* reverse
2020-05-02 08:44:35 -04:00
Travis Addair and Jirka
2950f66983
Fix Horovod distributed backend to set the root_gpu property ( #1669 )
...
* params
* drop acc
* Fix Horovod distributed backend to set the root_gpu
* Fixed test
* Fixed tests
* Fixed lint
* Set root_gpu during initialization
* chlog
Co-authored-by: Jirka <jirka.borovec@seznam.cz >
2020-05-01 14:13:35 -04:00
142bc0230e
Learning rate log callback ( #1498 )
...
* base implementation
* docs + implementation
* fix styling
* add lr string
* renaming
* CHANGELOG.md
* add tests
* Apply suggestions from code review
Co-Authored-By: Adrian Wälchli <aedu.waelchli@gmail.com >
* Apply suggestions from code review
* Update pytorch_lightning/callbacks/lr_logger.py
* Update pytorch_lightning/callbacks/lr_logger.py
* add test for naming
* base implementation
* docs + implementation
* fix styling
* add lr string
* renaming
* CHANGELOG.md
* add tests
* Apply suggestions from code review
Co-Authored-By: Adrian Wälchli <aedu.waelchli@gmail.com >
* Apply suggestions from code review
* Update pytorch_lightning/callbacks/lr_logger.py
* Update pytorch_lightning/callbacks/lr_logger.py
* add test for naming
* Update pytorch_lightning/callbacks/lr_logger.py
Co-Authored-By: Adrian Wälchli <aedu.waelchli@gmail.com >
* suggestions from code review
* fix styling
* rebase
* fix tests
Co-authored-by: Nicki Skafte <nugginea@gmail.com >
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com >
2020-04-30 08:06:41 -04:00
Nathan Breitsch
3eac6cfd4f
Don't convert namedtuple to tuple ( #1589 )
...
* Don't convert namedtuple to tuple
* Test namedtuples sent to device correctly
2020-04-30 08:04:50 -04:00
William Falcon and J. Borovec
d40425d257
added warning to crash ( #1625 )
...
* added warning to crash
* formatting
Co-authored-by: J. Borovec <jirka.borovec@seznam.cz >
2020-04-30 08:04:18 -04:00
Jacob Zhong and Jirka Borovec
f9c9e39ab8
Add log output for slurm ( #1657 )
...
* add log output for slurm
* change log levels
* formatting
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
2020-04-30 07:58:03 -04:00
Peter Yu
8d564b5e38
call on_load_checkpoint() when resuming from checkpoint ( #1666 )
2020-04-30 07:57:24 -04:00
Peter Yu and mergify[bot]
42d5cfc3b0
None check for filepath in ModelCheckpoint ( #1654 )
...
Check if the optional filepath is None before checking if it exists
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-04-29 16:36:28 +00:00
Dan Campbell
981758fd04
Only call load_spawn_weights if COLAB_GPU or KAGGLE_URL_BASE
...
environment variables are set
2020-04-27 19:46:29 -04:00
William Falcon
694f1d789d
Update __init__.py
2020-04-27 09:04:55 -04:00
William Falcon
63addd091c
ddp fix
2020-04-27 08:28:39 -04:00
William Falcon
a24c88ab08
ddp pickle
2020-04-27 08:19:19 -04:00
William Falcon
4c4d0e6bc6
Merge pull request #1635 from PyTorchLightning/pkl
...
Fixes CPU DDP breaking change and DDP change
2020-04-27 07:42:42 -04:00
William Falcon
8b82ce0903
Merge pull request #1630 from PyTorchLightning/hparams_logger
...
Allow metrics logged together with hparams
2020-04-27 07:25:12 -04:00
William Falcon
26933a97a3
Merge pull request #1632 from quinor/patch-1
...
Fix ModelCheckpoint not being picklable.
2020-04-27 07:24:32 -04:00
William Falcon
cebc74f7bc
ddp pickle
2020-04-27 07:19:12 -04:00
William Falcon
2181ad1bc7
ddp pickle
2020-04-27 07:12:04 -04:00
William Falcon
d2989f76e6
ddp pickle
2020-04-27 07:08:34 -04:00
William Falcon
d5dff384eb
ddp pickle
2020-04-27 07:07:03 -04:00
William Falcon
4aac5568a6
ddp pickle
2020-04-27 07:05:29 -04:00
William Falcon
6e86b59d21
ddp pickle
2020-04-27 06:51:42 -04:00
Justus Schock
f91b131ba2
Remove warning
2020-04-27 11:41:03 +02:00
Wojciech Jabłoński
735520b03e
Fix ModelCheckpoint not being fixable.
2020-04-27 11:02:33 +02:00
Justus Schock
cdbf2f4a37
Update tensorboard.py
2020-04-27 09:47:35 +02:00
Justus Schock
e309b55b38
Update tensorboard.py
2020-04-27 09:44:26 +02:00
William Falcon
acfb054103
Update __init__.py
2020-04-26 17:48:27 -04:00
William Falcon
c0a517a553
Merge pull request #1623 from PyTorchLightning/hparams
...
Hparams
2020-04-26 17:47:20 -04:00
William Falcon
879d879985
fix hparams issue
2020-04-26 17:27:45 -04:00
Jirka Borovec
80df5039f8
changelog ( #1616 )
...
* changelog
* warning
* pull
* typo
* typo
2020-04-26 16:11:22 -04:00
Rohit Gupta