From 00c14ce4a414582987a0cdfd29df67ba38a68058 Mon Sep 17 00:00:00 2001 From: Amog Kamsetty Date: Fri, 22 Jan 2021 00:31:33 -0800 Subject: [PATCH] [Object Spilling] Skip flaky tests (#13628) * skip flaky tests * lint * skip one more * fix --- python/ray/tests/test_object_spilling.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/python/ray/tests/test_object_spilling.py b/python/ray/tests/test_object_spilling.py index 745eb3baf..8319dbfca 100644 --- a/python/ray/tests/test_object_spilling.py +++ b/python/ray/tests/test_object_spilling.py @@ -343,7 +343,9 @@ def test_delete_objects(tmp_path, shutdown_only): @pytest.mark.skipif( - platform.system() == "Windows", reason="Failing on Windows.") + platform.system() in ["Windows", "Darwin"], + reason="Failing on " + "Windows and Mac.") def test_delete_objects_delete_while_creating(tmp_path, shutdown_only): # Limit our object store to 75 MiB of memory. temp_folder = tmp_path / "spill" @@ -393,7 +395,9 @@ def test_delete_objects_delete_while_creating(tmp_path, shutdown_only): @pytest.mark.skipif( - platform.system() == "Windows", reason="Failing on Windows.") + platform.system() in ["Windows", "Darwin"], + reason="Failing on Windows " + "and Mac.") def test_delete_objects_on_worker_failure(tmp_path, shutdown_only): # Limit our object store to 75 MiB of memory. temp_folder = tmp_path / "spill" @@ -541,6 +545,7 @@ def test_delete_objects_multi_node(tmp_path, ray_start_cluster): wait_for_condition(is_dir_empty) +@pytest.mark.skipif(platform.system() == "Windows", reason="Flaky on Windows.") def test_fusion_objects(tmp_path, shutdown_only): # Limit our object store to 75 MiB of memory. temp_folder = tmp_path / "spill"