wassname/ray
1
0
Fork 0
mirror of https://github.com/wassname/ray.git synced 2026-06-28 02:01:24 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix test_logging_to_driver and test_not_logging_to_driver (#5462)

Browse Source
This commit is contained in:
Hao Chen
2019-08-17 18:06:08 +08:00
committed by GitHub
parent 657ce4b3c7
commit 03d05c8765
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/ray/tests/test_basic.py
+10 -4
View File
@@ -2681,8 +2681,11 @@ def test_logging_to_driver(shutdown_only):
output_lines = captured["out"]
for i in range(200):
assert str(i) in output_lines
error_lines = captured["err"]
assert len(error_lines) == 0
# TODO(rkn): Check that no additional logs appear beyond what we expect
# and that there are no duplicate logs. Once we address the issue
# described in https://github.com/ray-project/ray/pull/5462, we should
# also check that nothing is logged to stderr.
def test_not_logging_to_driver(shutdown_only):
@@ -2703,8 +2706,11 @@ def test_not_logging_to_driver(shutdown_only):
output_lines = captured["out"]
assert len(output_lines) == 0
error_lines = captured["err"]
assert len(error_lines) == 0
# TODO(rkn): Check that no additional logs appear beyond what we expect
# and that there are no duplicate logs. Once we address the issue
# described in https://github.com/ray-project/ray/pull/5462, we should
# also check that nothing is logged to stderr.
@pytest.mark.skipif(