wassname/ray
1
0
Fork 0
mirror of https://github.com/wassname/ray.git synced 2026-06-29 19:32:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

Use subprocess.check_output in tests (#5465)

Browse Source
This commit is contained in:
Edward Oakes
2019-08-17 22:25:17 -07:00
committed by Robert Nishihara
parent c7ae4e5e1f
commit 0440c00019
4 changed files with 39 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/ray/tests/test_multi_node.py
+22 -22
View File
@@ -9,7 +9,7 @@ import time
import ray
from ray.utils import _random_string
from ray.tests.utils import (run_and_get_output, run_string_as_driver,
from ray.tests.utils import (run_string_as_driver,
run_string_as_driver_nonblocking)
@@ -272,60 +272,60 @@ def test_calling_start_ray_head():
# should also test the non-head node code path.
# Test starting Ray with no arguments.
run_and_get_output(["ray", "start", "--head"])
subprocess.Popen(["ray", "stop"]).wait()
subprocess.check_output(["ray", "start", "--head"])
subprocess.check_output(["ray", "stop"])
# Test starting Ray with a redis port specified.
run_and_get_output(["ray", "start", "--head", "--redis-port", "6379"])
subprocess.Popen(["ray", "stop"]).wait()
subprocess.check_output(["ray", "start", "--head", "--redis-port", "6379"])
subprocess.check_output(["ray", "stop"])
# Test starting Ray with a node IP address specified.
run_and_get_output(
subprocess.check_output(
["ray", "start", "--head", "--node-ip-address", "127.0.0.1"])
subprocess.Popen(["ray", "stop"]).wait()
subprocess.check_output(["ray", "stop"])
# Test starting Ray with the object manager and node manager ports
# specified.
run_and_get_output([
subprocess.check_output([
"ray", "start", "--head", "--object-manager-port", "12345",
"--node-manager-port", "54321"
])
subprocess.Popen(["ray", "stop"]).wait()
subprocess.check_output(["ray", "stop"])
# Test starting Ray with the number of CPUs specified.
run_and_get_output(["ray", "start", "--head", "--num-cpus", "2"])
subprocess.Popen(["ray", "stop"]).wait()
subprocess.check_output(["ray", "start", "--head", "--num-cpus", "2"])
subprocess.check_output(["ray", "stop"])
# Test starting Ray with the number of GPUs specified.
run_and_get_output(["ray", "start", "--head", "--num-gpus", "100"])
subprocess.Popen(["ray", "stop"]).wait()
subprocess.check_output(["ray", "start", "--head", "--num-gpus", "100"])
subprocess.check_output(["ray", "stop"])
# Test starting Ray with the max redis clients specified.
run_and_get_output(
subprocess.check_output(
["ray", "start", "--head", "--redis-max-clients", "100"])
subprocess.Popen(["ray", "stop"]).wait()
subprocess.check_output(["ray", "stop"])
if "RAY_USE_NEW_GCS" not in os.environ:
# Test starting Ray with redis shard ports specified.
run_and_get_output([
subprocess.check_output([
"ray", "start", "--head", "--redis-shard-ports", "6380,6381,6382"
])
subprocess.Popen(["ray", "stop"]).wait()
subprocess.check_output(["ray", "stop"])
# Test starting Ray with all arguments specified.
run_and_get_output([
subprocess.check_output([
"ray", "start", "--head", "--redis-port", "6379",
"--redis-shard-ports", "6380,6381,6382", "--object-manager-port",
"12345", "--num-cpus", "2", "--num-gpus", "0",
"--redis-max-clients", "100", "--resources", "{\"Custom\": 1}"
])
subprocess.Popen(["ray", "stop"]).wait()
subprocess.check_output(["ray", "stop"])
# Test starting Ray with invalid arguments.
with pytest.raises(Exception):
run_and_get_output(
with pytest.raises(subprocess.CalledProcessError):
subprocess.check_output(
["ray", "start", "--head", "--redis-address", "127.0.0.1:6379"])
subprocess.Popen(["ray", "stop"]).wait()
subprocess.check_output(["ray", "stop"])
# Test --block. Killing any child process should cause the command to exit.
blocked = subprocess.Popen(["ray", "start", "--head", "--block"])