From 15ae8816f76a00db2e28aec94997bc215bae7161 Mon Sep 17 00:00:00 2001 From: Tao Wang Date: Wed, 30 Sep 2020 14:38:17 +0800 Subject: [PATCH] [GCS]Remove useless / heavy heartbeat pub (#11132) --- python/ray/gcs_utils.py | 1 - src/ray/gcs/gcs_server/gcs_node_manager.cc | 2 -- src/ray/gcs/pubsub/gcs_pub_sub.h | 1 - 3 files changed, 4 deletions(-) diff --git a/python/ray/gcs_utils.py b/python/ray/gcs_utils.py index e840d20f0..18cd760f7 100644 --- a/python/ray/gcs_utils.py +++ b/python/ray/gcs_utils.py @@ -54,7 +54,6 @@ LOG_FILE_CHANNEL = "RAY_LOG_CHANNEL" REPORTER_CHANNEL = "RAY_REPORTER" # xray heartbeats -XRAY_HEARTBEAT_PATTERN = "HEARTBEAT:*".encode("ascii") XRAY_HEARTBEAT_BATCH_PATTERN = "HEARTBEAT_BATCH:".encode("ascii") # xray job updates diff --git a/src/ray/gcs/gcs_server/gcs_node_manager.cc b/src/ray/gcs/gcs_server/gcs_node_manager.cc index f314772ad..97b706ce1 100644 --- a/src/ray/gcs/gcs_server/gcs_node_manager.cc +++ b/src/ray/gcs/gcs_server/gcs_node_manager.cc @@ -241,8 +241,6 @@ void GcsNodeManager::HandleReportHeartbeat(const rpc::ReportHeartbeatRequest &re node_failure_detector_->HandleHeartbeat(node_id, *heartbeat_data); }); GCS_RPC_SEND_REPLY(send_reply_callback, reply, Status::OK()); - RAY_CHECK_OK(gcs_pub_sub_->Publish(HEARTBEAT_CHANNEL, node_id.Hex(), - heartbeat_data->SerializeAsString(), nullptr)); } void GcsNodeManager::HandleGetResources(const rpc::GetResourcesRequest &request, diff --git a/src/ray/gcs/pubsub/gcs_pub_sub.h b/src/ray/gcs/pubsub/gcs_pub_sub.h index 8ac06c9bf..0c4bef83b 100644 --- a/src/ray/gcs/pubsub/gcs_pub_sub.h +++ b/src/ray/gcs/pubsub/gcs_pub_sub.h @@ -32,7 +32,6 @@ namespace gcs { #define OBJECT_CHANNEL "OBJECT" #define TASK_CHANNEL "TASK" #define TASK_LEASE_CHANNEL "TASK_LEASE" -#define HEARTBEAT_CHANNEL "HEARTBEAT" #define HEARTBEAT_BATCH_CHANNEL "HEARTBEAT_BATCH" #define ERROR_INFO_CHANNEL "ERROR_INFO"