From 162f361dab06a93133d68c75355b466ca451f76d Mon Sep 17 00:00:00 2001 From: SangBin Cho Date: Mon, 7 Dec 2020 22:01:18 -0800 Subject: [PATCH] [Logging] Fix log monitor issue (#12588) * Try fixing issues. * Verficiation. --- dashboard/agent.py | 1 + dashboard/dashboard.py | 1 + python/ray/log_monitor.py | 3 ++- 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/dashboard/agent.py b/dashboard/agent.py index d76c17f2d..676312245 100644 --- a/dashboard/agent.py +++ b/dashboard/agent.py @@ -307,4 +307,5 @@ if __name__ == "__main__": "error:\n{}".format(platform.uname()[1], traceback_str)) ray.utils.push_error_to_driver_through_redis( redis_client, ray_constants.DASHBOARD_AGENT_DIED_ERROR, message) + logger.exception(message) raise e diff --git a/dashboard/dashboard.py b/dashboard/dashboard.py index 5fecebdb5..80765b647 100644 --- a/dashboard/dashboard.py +++ b/dashboard/dashboard.py @@ -207,4 +207,5 @@ if __name__ == "__main__": if isinstance(e, OSError) and e.errno == errno.ENOENT: logger.warning(message) else: + logger.exception(message) raise e diff --git a/python/ray/log_monitor.py b/python/ray/log_monitor.py index 4932b7338..ac5fa5296 100644 --- a/python/ray/log_monitor.py +++ b/python/ray/log_monitor.py @@ -133,7 +133,7 @@ class LogMonitor: job_match = JOB_LOG_PATTERN.match(file_path) if job_match: job_id = job_match.group(2) - worker_pid = job_match.group(3) + worker_pid = int(job_match.group(3)) else: job_id = None worker_pid = None @@ -361,4 +361,5 @@ if __name__ == "__main__": f"failed with the following error:\n{traceback_str}") ray.utils.push_error_to_driver_through_redis( redis_client, ray_constants.LOG_MONITOR_DIED_ERROR, message) + logger.error(message) raise e