[RLlib] Solve PyTorch/TF-eager A3C async race condition between calling model and its value function. (#13467)

This commit is contained in:
Sven Mika
2021-01-18 10:29:03 -08:00
committed by GitHub
parent 516eb77080
commit 1f00f834ac
7 changed files with 63 additions and 9 deletions
+27
View File
@@ -0,0 +1,27 @@
from typing import Callable
def with_lock(func: Callable):
"""Use as decorator (@withlock) around object methods that need locking.
Note: The object must have a self._lock = threading.Lock() property.
Locking thus works on the object level (no two locked methods of the same
object can be called asynchronously).
Args:
func (Callable): The function to decorate/wrap.
Returns:
Callable: The wrapped (object-level locked) function.
"""
def wrapper(self, *a, **k):
try:
with self._lock:
return func(self, *a, **k)
except AttributeError:
raise AttributeError(
"Object {} must have a `self._lock` property (assigned to a "
"threading.Lock() object in its constructor)!".format(self))
return wrapper