[Placement Group] Remove warning msg for placement groups. (#11034)

* Done.

* Addressed code review.

* Fixed typo.

* Addressed code review.
This commit is contained in:
SangBin Cho
2020-09-25 20:53:42 -07:00
committed by GitHub
parent 8f79b4e45e
commit 29663d89f1
3 changed files with 37 additions and 3 deletions
+14 -1
View File
@@ -8,7 +8,8 @@ except ImportError:
pytest_timeout = None
import ray
from ray.test_utils import get_other_nodes, wait_for_condition
from ray.test_utils import (get_other_nodes, wait_for_condition,
get_error_message)
import ray.cluster_utils
from ray._raylet import PlacementGroupID
from ray.util.placement_group import (PlacementGroup,
@@ -846,5 +847,17 @@ def test_capture_child_tasks(ray_start_cluster):
assert len(node_id_set) == 1
def test_ready_warning_suppressed(ray_start_regular, error_pubsub):
p = error_pubsub
# Create an infeasible pg.
pg = ray.util.placement_group([{"CPU": 2}] * 2, strategy="STRICT_PACK")
with pytest.raises(ray.exceptions.GetTimeoutError):
ray.get(pg.ready(), timeout=0.5)
errors = get_error_message(
p, 1, ray.ray_constants.INFEASIBLE_TASK_ERROR, timeout=0.1)
assert len(errors) == 0
if __name__ == "__main__":
sys.exit(pytest.main(["-v", __file__]))
+5 -1
View File
@@ -78,9 +78,13 @@ class PlacementGroup:
return len(self.bundle_cache)
def _get_none_zero_resource(self, bundle: List[Dict]):
# This number shouldn't be changed.
# When it is specified, node manager won't warn about infeasible
# tasks.
INFEASIBLE_TASK_SUPPRESS_MAGIC_NUMBER = 0.0101
for key, value in bundle.items():
if value > 0:
value = min(value, 0.001)
value = INFEASIBLE_TASK_SUPPRESS_MAGIC_NUMBER
return key, value
assert False, "This code should be unreachable."