wassname/ray
1
0
Fork 0
mirror of https://github.com/wassname/ray.git synced 2026-08-17 11:25:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

[Placement Group] Remove warning msg for placement groups. (#11034)

Browse Source 
* Done.

* Addressed code review.

* Fixed typo.

* Addressed code review.
This commit is contained in:
SangBin Cho
2020-09-25 20:53:42 -07:00
committed by GitHub
parent 8f79b4e45e
commit 29663d89f1
3 changed files with 37 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ray/raylet/node_manager.cc
+18 -1
View File
@@ -2159,8 +2159,25 @@ void NodeManager::ScheduleTasks(
for (const auto &task : local_queues_.GetTasks(TaskState::PLACEABLE)) {
task_dependency_manager_.TaskPending(task);
move_task_set.insert(task.GetTaskSpecification().TaskId());
// This block is used to suppress infeasible task warning.
bool suppress_warning = false;
const auto &required_resources = task.GetTaskSpecification().GetRequiredResources();
const auto &resources_map = required_resources.GetResourceMap();
const auto &it = resources_map.begin();
// It is a hack to suppress infeasible task warning.
// If the first resource of a task requires this magic number, infeasible warning is
// suppressed. It is currently only used by placement group ready API. We don't want
// to have this in ray_config_def.h because the use case is very narrow, and we don't
// want to expose this anywhere.
double INFEASIBLE_TASK_SUPPRESS_MAGIC_NUMBER = 0.0101;
if (it != resources_map.end() &&
it->second == INFEASIBLE_TASK_SUPPRESS_MAGIC_NUMBER) {
suppress_warning = true;
}
// Push a warning to the task's driver that this task is currently infeasible.
{
if (!suppress_warning) {
// TODO(rkn): Define this constant somewhere else.
std::string type = "infeasible_task";
std::ostringstream error_message;