[tune] Support "None" for upload_dir

This commit is contained in:
Richard Liaw
2018-11-09 22:02:08 -08:00
committed by Eric Liang
parent a51d618d88
commit 29c182d449
2 changed files with 17 additions and 2 deletions
+2 -2
View File
@@ -85,7 +85,7 @@ class Experiment(object):
repeat=1,
num_samples=1,
local_dir=None,
upload_dir="",
upload_dir=None,
checkpoint_freq=0,
checkpoint_at_end=False,
max_failures=3,
@@ -97,7 +97,7 @@ class Experiment(object):
"trial_resources": trial_resources,
"num_samples": num_samples,
"local_dir": local_dir or DEFAULT_RESULTS_DIR,
"upload_dir": upload_dir,
"upload_dir": upload_dir or "", # argparse converts None to "null"
"checkpoint_freq": checkpoint_freq,
"checkpoint_at_end": checkpoint_at_end,
"max_failures": max_failures,
+15
View File
@@ -185,6 +185,21 @@ class TrainableFunctionApiTest(unittest.TestCase):
}
})
def testUploadDirNone(self):
def train(config, reporter):
reporter(timesteps_total=1)
[trial] = run_experiments({
"foo": {
"run": train,
"upload_dir": None,
"config": {
"a": "b"
},
}
})
self.assertFalse(trial.upload_dir)
def testLogdirStartingWithTilde(self):
local_dir = '~/ray_results/local_dir'