wassname/ray
1
0
Fork 0
mirror of https://github.com/wassname/ray.git synced 2026-08-19 12:30:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

[core] Add long running regression test for distributed ref counting and fix memory leak (#7302)

Browse Source 
* Add long running test for serialized IDs and fix mem leak

* comment
This commit is contained in:
Stephanie Wang
2020-02-24 17:58:42 -08:00
committed by GitHub
parent b97b8c2be1
commit 2c1f4fd82c
3 changed files with 78 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ray/core_worker/reference_count.cc
+5 -4
View File
@@ -218,8 +218,7 @@ void ReferenceCounter::DeleteReferenceInternal(ReferenceTable::iterator it,
std::vector<ObjectID> *deleted) {
const ObjectID id = it->first;
RAY_LOG(DEBUG) << "Attempting to delete object " << id;
if (distributed_ref_counting_enabled_ && it->second.RefCount() == 0 &&
it->second.on_ref_removed) {
if (it->second.RefCount() == 0 && it->second.on_ref_removed) {
RAY_LOG(DEBUG) << "Calling on_ref_removed for object " << id;
it->second.on_ref_removed(id);
it->second.on_ref_removed = nullptr;
@@ -257,7 +256,8 @@ void ReferenceCounter::DeleteReferenceInternal(ReferenceTable::iterator it,
// If this object ID was nested in a borrowed object, make sure that
// we have already returned this information through a previous
// GetAndClearLocalBorrowers call.
RAY_CHECK(!inner_it->second.contained_in_borrowed_id.has_value());
RAY_CHECK(!inner_it->second.contained_in_borrowed_id.has_value())
<< "Outer object " << id << ", inner object " << inner_id;
}
DeleteReferenceInternal(inner_it, deleted);
}
@@ -266,8 +266,8 @@ void ReferenceCounter::DeleteReferenceInternal(ReferenceTable::iterator it,
// Perform the deletion.
if (should_delete_value) {
RAY_LOG(DEBUG) << "Deleting object " << id;
if (it->second.on_delete) {
RAY_LOG(DEBUG) << "Calling on_delete for object " << id;
it->second.on_delete(id);
it->second.on_delete = nullptr;
}
@@ -276,6 +276,7 @@ void ReferenceCounter::DeleteReferenceInternal(ReferenceTable::iterator it,
}
}
if (should_delete_reference) {
RAY_LOG(DEBUG) << "Deleting Reference to object " << id;
object_id_refs_.erase(it);
}
}