[Autoscaler/Core] Remove autoscaler spam (#12952)

This commit is contained in:
Alex Wu
2020-12-18 18:22:45 -08:00
committed by GitHub
parent ac5ea2c13d
commit 404161a3ff
3 changed files with 45 additions and 12 deletions
@@ -258,6 +258,7 @@ std::shared_ptr<rpc::GcsNodeInfo> GcsNodeManager::RemoveNode(
// Remove from cluster resources.
gcs_resource_manager_->OnNodeDead(node_id);
resources_buffer_.erase(node_id);
node_resource_usages_.erase(node_id);
if (!is_intended) {
// Broadcast a warning to all of the drivers indicating that the node
// has been marked as dead.
@@ -41,11 +41,43 @@ TEST_F(GcsNodeManagerTest, TestManagement) {
auto node = Mocker::GenNodeInfo();
auto node_id = NodeID::FromBinary(node->node_id());
{
rpc::GetAllResourceUsageRequest request;
rpc::GetAllResourceUsageReply reply;
auto send_reply_callback = [](ray::Status status, std::function<void()> f1,
std::function<void()> f2) {};
node_manager.HandleGetAllResourceUsage(request, &reply, send_reply_callback);
ASSERT_EQ(reply.resource_usage_data().batch().size(), 0);
}
node_manager.AddNode(node);
ASSERT_EQ(node, node_manager.GetAliveNode(node_id).value());
rpc::ReportResourceUsageRequest report_request;
(*report_request.mutable_resources()->mutable_resources_available())["CPU"] = 2;
(*report_request.mutable_resources()->mutable_resources_total())["CPU"] = 2;
node_manager.UpdateNodeResourceUsage(node_id, report_request);
{
rpc::GetAllResourceUsageRequest request;
rpc::GetAllResourceUsageReply reply;
auto send_reply_callback = [](ray::Status status, std::function<void()> f1,
std::function<void()> f2) {};
node_manager.HandleGetAllResourceUsage(request, &reply, send_reply_callback);
ASSERT_EQ(reply.resource_usage_data().batch().size(), 1);
}
node_manager.RemoveNode(node_id);
ASSERT_TRUE(!node_manager.GetAliveNode(node_id).has_value());
{
rpc::GetAllResourceUsageRequest request;
rpc::GetAllResourceUsageReply reply;
auto send_reply_callback = [](ray::Status status, std::function<void()> f1,
std::function<void()> f2) {};
node_manager.HandleGetAllResourceUsage(request, &reply, send_reply_callback);
ASSERT_EQ(reply.resource_usage_data().batch().size(), 0);
}
}
TEST_F(GcsNodeManagerTest, TestListener) {