From 4946c1e6de44419844d521f22d65dde07d93b221 Mon Sep 17 00:00:00 2001 From: Sumanth Ratna Date: Mon, 19 Oct 2020 15:42:53 -0400 Subject: [PATCH] [docker] Minor improvements (#11352) --- ci/travis/build-docker-images.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ci/travis/build-docker-images.py b/ci/travis/build-docker-images.py index 00ec2e8e0..dc9f6498c 100644 --- a/ci/travis/build-docker-images.py +++ b/ci/travis/build-docker-images.py @@ -19,7 +19,7 @@ PYTHON_WHL_VERSION = "cp37m" def _merge_build(): - return os.environ.get("TRAVIS_PULL_REQUEST") == "false" + return os.environ.get("TRAVIS_PULL_REQUEST").lower() == "false" def _release_build(): @@ -45,7 +45,7 @@ def _get_wheel_name(): f"{_get_root_dir()}/.whl/*{PYTHON_WHL_VERSION}-manylinux*") assert len(matches) == 1, ( f"Found ({len(matches)}) matches " - "'*{PYTHON_WHL_VERSION}-manylinux*' instead of 1") + f"'*{PYTHON_WHL_VERSION}-manylinux*' instead of 1") return os.path.basename(matches[0]) @@ -181,7 +181,7 @@ def build_ray_ml(): def push_and_tag_images(push_base_images: bool): if _merge_build(): docker_password = os.environ.get("DOCKER_PASSWORD") - assert docker_password is not None, "DOCKER_PASSWORD not set." + assert docker_password, "DOCKER_PASSWORD not set." DOCKER_CLIENT.api.login( username=DOCKER_USERNAME, password=os.environ.get("DOCKER_PASSWORD"))