From 72297dc46f74484cf2394c939b02abd2e55d5274 Mon Sep 17 00:00:00 2001 From: Alex Wu Date: Wed, 29 Jul 2020 13:17:46 -0700 Subject: [PATCH] [Core] Socket creation race condition bug fixes (#9764) * fix issues * hot fixes * test * test * Always info log --- src/ray/common/client_connection.cc | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/ray/common/client_connection.cc b/src/ray/common/client_connection.cc index aa6eccd6e..e0e04797f 100644 --- a/src/ray/common/client_connection.cc +++ b/src/ray/common/client_connection.cc @@ -48,9 +48,11 @@ Status ConnectSocketRetry(local_stream_socket &socket, const std::string &endpoi break; } if (num_attempts > 0) { - RAY_LOG(ERROR) << "Retrying to connect to socket for endpoint " << endpoint - << " (num_attempts = " << num_attempts - << ", num_retries = " << num_retries << ")"; + // Socket is created by the raylet. Due to a race condition it might not + // be created before we try connecting. + RAY_LOG(INFO) << "Retrying to connect to socket for endpoint " << endpoint + << " (num_attempts = " << num_attempts + << ", num_retries = " << num_retries << ")"; } // Sleep for timeout milliseconds. std::this_thread::sleep_for(std::chrono::milliseconds(timeout_in_ms));