From 731ed8d23264d2ea2c34642bfb1cc7f4ae5111b5 Mon Sep 17 00:00:00 2001 From: SangBin Cho Date: Tue, 9 Jun 2020 15:46:17 -0700 Subject: [PATCH] [Core] Fix a detached actor bug fix when GCS actor management is off. (#8843) --- python/ray/tests/test_actor_advanced.py | 2 ++ python/ray/util/named_actors.py | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/python/ray/tests/test_actor_advanced.py b/python/ray/tests/test_actor_advanced.py index 32740eb34..0bdd22f74 100644 --- a/python/ray/tests/test_actor_advanced.py +++ b/python/ray/tests/test_actor_advanced.py @@ -712,6 +712,8 @@ def test_detached_actor_cleanup(ray_start_regular): detached_actor = DetachedActor.options(name=actor_name).remote() # Wait for detached actor creation. assert ray.get(detached_actor.ping.remote()) == "pong" + del detached_actor + detached_actor = ray.get_actor(dup_actor_name) ray.kill(detached_actor) # Wait until actor dies. actor_status = ray.actors(actor_id=detached_actor._actor_id.hex()) diff --git a/python/ray/util/named_actors.py b/python/ray/util/named_actors.py index 247fbd88a..d929815a1 100644 --- a/python/ray/util/named_actors.py +++ b/python/ray/util/named_actors.py @@ -77,7 +77,7 @@ def _register_actor(name, actor_handle): raise ValueError("An actor with name={} already exists".format(name)) # Add the actor to Redis if it does not already exist. - _internal_kv_put(actor_name, pickle.dumps(actor_handle)) + _internal_kv_put(actor_name, pickle.dumps(actor_handle), overwrite=True) def register_actor(name, actor_handle):