wassname/ray
1
0
Fork 0
mirror of https://github.com/wassname/ray.git synced 2026-08-11 11:24:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

[Dashboard] Authentication (#7888)

Browse Source 
* Change authentication schema.

Authentication implementation.

* Formatting.

* Fix a minor style.

* Fix tests.

* Removed url validation.
This commit is contained in:
SangBin Cho
2020-04-04 19:40:54 -07:00
committed by GitHub
parent 3c91ff1f63
commit 73fd78316d
5 changed files with 36 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/ray/tests/test_metrics_export.py
+11 -6
View File
@@ -10,7 +10,7 @@ from ray.dashboard.metrics_exporter.schema import (AuthResponse, BaseModel,
ValidationError, Field)
MOCK_DASHBOARD_ID = "1234"
MOCK_DASHBOARD_ADDRESS = "127.0.0.1:9081"
MOCK_DASHBOARD_ADDRESS = "http://127.0.0.1:9081"
MOCK_ACCESS_TOKEN = "1234"
@@ -63,12 +63,14 @@ def test_client_invalid_request_status_returned(auth_request, mock_controller):
@patch("ray.dashboard.metrics_exporter.api.authentication_request")
def test_authentication(auth_request, mock_controller):
auth_request.return_value = AuthResponse(
dashboard_url=MOCK_DASHBOARD_ADDRESS, access_token=MOCK_ACCESS_TOKEN)
access_token_dashboard=MOCK_ACCESS_TOKEN,
access_token_ingest=MOCK_ACCESS_TOKEN)
exporter, client = _setup_client_and_exporter(mock_controller)
assert client.enabled is False
client._authenticate()
assert client.dashboard_url == MOCK_DASHBOARD_ADDRESS
assert client.dashboard_url == "{address}/dashboard/{access_token}".format(
address=MOCK_DASHBOARD_ADDRESS, access_token=MOCK_ACCESS_TOKEN)
assert client.enabled is True
@@ -82,7 +84,8 @@ def test_start_exporting_metrics_without_authentication(
are not authenticated.
"""
auth_request.return_value = AuthResponse(
dashboard_url=MOCK_DASHBOARD_ADDRESS, access_token=MOCK_ACCESS_TOKEN)
access_token_dashboard=MOCK_ACCESS_TOKEN,
access_token_ingest=MOCK_ACCESS_TOKEN)
exporter, client = _setup_client_and_exporter(mock_controller)
# start_exporting_metrics should succeed.
@@ -102,7 +105,8 @@ def test_start_exporting_metrics_with_authentication(auth_request,
should not authenticate users.
"""
auth_request.return_value = AuthResponse(
dashboard_url=MOCK_DASHBOARD_ADDRESS, access_token=MOCK_ACCESS_TOKEN)
access_token_dashboard=MOCK_ACCESS_TOKEN,
access_token_ingest=MOCK_ACCESS_TOKEN)
exporter, client = _setup_client_and_exporter(mock_controller)
# Already authenticated.
client._authenticate()
@@ -121,7 +125,8 @@ def test_start_exporting_metrics_with_authentication(auth_request,
@patch("ray.dashboard.metrics_exporter.api.authentication_request")
def test_start_exporting_metrics_succeed(auth_request, mock_controller, start):
auth_request.return_value = AuthResponse(
dashboard_url=MOCK_DASHBOARD_ADDRESS, access_token=MOCK_ACCESS_TOKEN)
access_token_dashboard=MOCK_ACCESS_TOKEN,
access_token_ingest=MOCK_ACCESS_TOKEN)
exporter, client = _setup_client_and_exporter(mock_controller)
result, error = client.start_exporting_metrics()