From 7b87da7f03595c039dcc6a7af260a77f5aecc872 Mon Sep 17 00:00:00 2001 From: Ian Rodney Date: Sun, 9 Aug 2020 21:31:28 -0700 Subject: [PATCH] Properly call mkdir on rsync (#9995) --- python/ray/autoscaler/command_runner.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/python/ray/autoscaler/command_runner.py b/python/ray/autoscaler/command_runner.py index 1b2ca4c12..21952491f 100644 --- a/python/ray/autoscaler/command_runner.py +++ b/python/ray/autoscaler/command_runner.py @@ -484,8 +484,8 @@ class DockerCommandRunner(SSHCommandRunner): protected_path = target if target.find("/root") == 0: target = target.replace("/root", "/tmp/root") - self.ssh_command_runner.run( - f"mkdir -p {os.path.dirname(target)}", run_env="host") + self.ssh_command_runner.run( + f"mkdir -p {os.path.dirname(target.rstrip('/'))}", run_env="host") self.ssh_command_runner.run_rsync_up(source, target) if self._check_container_status(): self.ssh_command_runner.run("docker cp {} {}:{}".format( @@ -496,8 +496,8 @@ class DockerCommandRunner(SSHCommandRunner): protected_path = source if source.find("/root") == 0: source = source.replace("/root", "/tmp/root") - self.ssh_command_runner.run( - f"mkdir -p {os.path.dirname(source)}", run_env="host") + self.ssh_command_runner.run( + f"mkdir -p {os.path.dirname(source.rstrip('/'))}", run_env="host") self.ssh_command_runner.run("docker cp {}:{} {}".format( self.docker_name, self._docker_expand_user(protected_path), source))