diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 02ff1112a..abbdc6f01 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,5 +1,7 @@ + + ## Why are these changes needed? diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst index f97704a4d..f0265bcd5 100644 --- a/CONTRIBUTING.rst +++ b/CONTRIBUTING.rst @@ -25,3 +25,22 @@ To contribute a patch: .. _`ray-dev@googlegroups.com`: https://groups.google.com/forum/#!forum/ray-dev .. _`GitHub Issues`: https://github.com/ray-project/ray/issues .. _`StackOverflow`: https://stackoverflow.com/questions/tagged/ray + +PR Review Process +----------------- + +For contributors who are in the ray-project organization: +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +- When you first create a PR, add an reviewer to the `assignee` section. +- Assignees will review your PR and add `@author-action-required` label if further actions are required. +- Address their comments and remove `@author-action-required` label from the PR. +- Repeat this process until assignees approve your PR. +- Once the PR is approved, the author is in charge of ensuring the PR passes the build. Add `test-ok` label if the build succeeds. +- Committers will merge the PR once the build is passing. + +For contributors who are not in the ray-project organization: +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +- Your PRs will have assignees shortly. Assignees or PRs will be actively engaging with contributors to merge the PR. +- Please actively ping assignees after you address your comments!