wassname/ray
1
0
Fork 0
mirror of https://github.com/wassname/ray.git synced 2026-06-28 01:16:06 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove suppressing duplicate error message (missed a couple)

Browse Source
This commit is contained in:
Eric Liang
2018-11-05 23:37:14 -08:00
committed by GitHub
parent 80f63696ac
commit 8356a01dd6
1 changed files with 2 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/ray/worker.py
+2 -17
View File
@@ -1791,12 +1791,6 @@ def print_error_messages(worker):
worker.error_message_pubsub_client.subscribe("__keyspace@0__:ErrorKeys")
num_errors_received = 0
# Keep a set of all the error messages that we've seen so far in order to
# avoid printing the same error message repeatedly. This is especially
# important when running a script inside of a tool like screen where
# scrolling is difficult.
old_error_messages = set()
# Get the exports that occurred before the call to subscribe.
with worker.lock:
error_keys = worker.redis_client.lrange("ErrorKeys", 0, -1)
@@ -1804,11 +1798,7 @@ def print_error_messages(worker):
if error_applies_to_driver(error_key, worker=worker):
error_message = ray.utils.decode(
worker.redis_client.hget(error_key, "message"))
if error_message not in old_error_messages:
logger.error(error_message)
old_error_messages.add(error_message)
else:
logger.error("Suppressing duplicate error message.")
logger.error(error_message)
num_errors_received += 1
try:
@@ -1819,12 +1809,7 @@ def print_error_messages(worker):
if error_applies_to_driver(error_key, worker=worker):
error_message = ray.utils.decode(
worker.redis_client.hget(error_key, "message"))
if error_message not in old_error_messages:
logger.error(error_message)
old_error_messages.add(error_message)
else:
logger.error(
"Suppressing duplicate error message.")
logger.error(error_message)
num_errors_received += 1
except redis.ConnectionError:
# When Redis terminates the listen call will throw a ConnectionError,