From 8c241d5f1d66f618bf5cf4b2347e4d0cfab9b945 Mon Sep 17 00:00:00 2001 From: SangBin Cho Date: Thu, 24 Sep 2020 11:44:52 -0700 Subject: [PATCH] [Core] Use node ip address properly in ray.init (#10829) * Fix. * Addressed code review. * Addressed code review. --- python/ray/node.py | 1 + python/ray/worker.py | 13 +++++++++---- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/python/ray/node.py b/python/ray/node.py index 885049815..5a7e9e00f 100644 --- a/python/ray/node.py +++ b/python/ray/node.py @@ -104,6 +104,7 @@ class Node: head), "LRU Evict can only be passed into the head node." self._raylet_ip_address = raylet_ip_address + self.metrics_agent_port = (ray_params.metrics_agent_port or self._get_unused_port()[0]) self._metrics_export_port = ray_params.metrics_export_port diff --git a/python/ray/worker.py b/python/ray/worker.py index 7210d5a0a..4e96679ba 100644 --- a/python/ray/worker.py +++ b/python/ray/worker.py @@ -625,6 +625,11 @@ def init( "please call ray.init() or ray.init(address=\"auto\") on the " "driver.") + # Convert hostnames to numerical IP address. + if _node_ip_address is not None: + node_ip_address = services.address_to_ip(_node_ip_address) + raylet_ip_address = node_ip_address + if address: redis_address, _, _ = services.validate_redis_address(address) else: @@ -662,8 +667,8 @@ def init( # In this case, we need to start a new cluster. ray_params = ray.parameter.RayParams( redis_address=redis_address, - node_ip_address=None, - raylet_ip_address=None, + node_ip_address=node_ip_address, + raylet_ip_address=raylet_ip_address, object_ref_seed=None, driver_mode=driver_mode, redirect_worker_output=None, @@ -727,8 +732,8 @@ def init( # In this case, we only need to connect the node. ray_params = ray.parameter.RayParams( - node_ip_address=None, - raylet_ip_address=None, + node_ip_address=node_ip_address, + raylet_ip_address=raylet_ip_address, redis_address=redis_address, redis_password=_redis_password, object_ref_seed=None,