From 9d7b8b58a2afebf3c2f5686f9f78b5d285efddd9 Mon Sep 17 00:00:00 2001 From: Ameer Haj Ali Date: Mon, 1 Feb 2021 09:29:57 +0200 Subject: [PATCH] [autoscaler] Remove min workers from multi node type examples (#13814) * prepare for head node * move command runner interface outside _private * remove space * Eric * flake * min_workers in multi node type * fixing edge cases * eric not idle * fix target_workers to consider min_workers of node types * idle timeout * minor * minor fix * test * lint * eric v2 * eric 3 * min_workers constraint before bin packing * Update resource_demand_scheduler.py * Revert "Update resource_demand_scheduler.py" This reverts commit 818a63a2c86d8437b3ef21c5035d701c1d1127b5. * reducing diff * make get_nodes_to_launch return a dict * merge * weird merge fix * auto fill instance types for AWS * Alex/Eric * Update doc/source/cluster/autoscaling.rst * merge autofill and input from user * logger.exception * make the yaml use the default autofill * docs Eric * remove test_autoscaler_yaml from windows tests * lets try changing the test a bit * return test * lets see * edward * Limit max launch concurrency * commenting frac TODO * move to resource demand scheduler * use STATUS UP TO DATE * Eric * make logger of gc freed refs debug instead of info * add cluster name to docker mount prefix directory * grrR * fix tests * moving docker directory to sdk * move the import to prevent circular dependency * smallf fix * ian * fix max launch concurrency bug to assume failing nodes as pending and consider only load_metric's connected nodes as running * small fix * remove global min_workers from mult-node-type-examples Co-authored-by: Ameer Haj Ali Co-authored-by: Alex Wu Co-authored-by: Alex Wu Co-authored-by: Eric Liang Co-authored-by: Ameer Haj Ali --- python/ray/autoscaler/_private/util.py | 2 +- python/ray/autoscaler/aws/example-multi-node-type.yaml | 1 - python/ray/autoscaler/staroid/example-multi-node-type.yaml | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/python/ray/autoscaler/_private/util.py b/python/ray/autoscaler/_private/util.py index 32758dec6..39ebd5e79 100644 --- a/python/ray/autoscaler/_private/util.py +++ b/python/ray/autoscaler/_private/util.py @@ -124,7 +124,7 @@ def rewrite_legacy_yaml_to_available_node_types( }, } config["head_node_type"] = NODE_TYPE_LEGACY_HEAD - + del config["min_workers"] return config diff --git a/python/ray/autoscaler/aws/example-multi-node-type.yaml b/python/ray/autoscaler/aws/example-multi-node-type.yaml index 1a83b8cc6..19584c69d 100644 --- a/python/ray/autoscaler/aws/example-multi-node-type.yaml +++ b/python/ray/autoscaler/aws/example-multi-node-type.yaml @@ -1,6 +1,5 @@ # Experimental: an example of configuring a mixed-node-type cluster. cluster_name: multi_node_type -min_workers: 1 max_workers: 40 # The autoscaler will scale up the cluster faster with higher upscaling speed. diff --git a/python/ray/autoscaler/staroid/example-multi-node-type.yaml b/python/ray/autoscaler/staroid/example-multi-node-type.yaml index 563e3a74c..f0291963e 100644 --- a/python/ray/autoscaler/staroid/example-multi-node-type.yaml +++ b/python/ray/autoscaler/staroid/example-multi-node-type.yaml @@ -1,6 +1,5 @@ # an example of configuring a mixed-node-type cluster. cluster_name: multi-node-type # name with 'a-z' and '-' -min_workers: 1 max_workers: 40 # The autoscaler will scale up the cluster faster with higher upscaling speed.