[tune] Safer try-catch for TensorboardX (#8174)

Co-Authored-By: Kristian Hartikainen <kristian.hartikainen@gmail.com>
This commit is contained in:
Richard Liaw
2020-04-25 13:08:37 -07:00
committed by GitHub
co-authored by Kristian Hartikainen
parent 13c14eac07
commit 9dd3490c38
2 changed files with 46 additions and 7 deletions
+20 -1
View File
@@ -46,7 +46,7 @@ class LoggerSuite(unittest.TestCase):
logger.close()
def testTBX(self):
config = {"a": 2, "b": 5, "c": {"c": {"D": 123}, "e": None}}
config = {"a": 2, "b": [1, 2], "c": {"c": {"D": 123}}}
t = Trial(evaluated_params=config, trial_id="tbx")
logger = TBXLogger(config=config, logdir=self.test_dir, trial=t)
logger.on_result(result(0, 4))
@@ -54,6 +54,25 @@ class LoggerSuite(unittest.TestCase):
logger.on_result(result(2, 4, score=[1, 2, 3], hello={"world": 1}))
logger.close()
def testBadTBX(self):
config = {"b": (1, 2, 3)}
t = Trial(evaluated_params=config, trial_id="tbx")
logger = TBXLogger(config=config, logdir=self.test_dir, trial=t)
logger.on_result(result(0, 4))
logger.on_result(result(2, 4, score=[1, 2, 3], hello={"world": 1}))
with self.assertLogs("ray.tune.logger", level="INFO") as cm:
logger.close()
assert "INFO" in cm.output[0]
config = {"None": None}
t = Trial(evaluated_params=config, trial_id="tbx")
logger = TBXLogger(config=config, logdir=self.test_dir, trial=t)
logger.on_result(result(0, 4))
logger.on_result(result(2, 4, score=[1, 2, 3], hello={"world": 1}))
with self.assertLogs("ray.tune.logger", level="INFO") as cm:
logger.close()
assert "INFO" in cm.output[0]
if __name__ == "__main__":
import pytest