wassname/ray
1
0
Fork 0
mirror of https://github.com/wassname/ray.git synced 2026-08-09 12:20:09 +08:00
Code Issues Packages Projects Releases Wiki Activity

[tune] Add error case for member functions passed as stopping c… (#5823)

Browse Source
This commit is contained in:
Ujval Misra
2019-10-03 09:49:03 -07:00
committed by Richard Liaw
parent 2fb7d7846f
commit 9df6eda84f
2 changed files with 37 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/ray/tune/experiment.py
+8 -3
View File
@@ -7,6 +7,7 @@ import inspect
import logging
import os
import six
import types
from ray.tune.error import TuneError
from ray.tune.registry import register_trainable
@@ -92,9 +93,13 @@ class Experiment(object):
if not isinstance(stop, dict) and not callable(stop):
raise ValueError("Invalid stop criteria: {}. Must be a callable "
"or dict".format(stop))
if callable(stop) and len(inspect.getargspec(stop).args) != 2:
raise ValueError("Invalid stop criteria: {}. Callable criteria "
"must take exactly 2 parameters.".format(stop))
if callable(stop):
nargs = len(inspect.getargspec(stop).args)
is_method = isinstance(stop, types.MethodType)
if (is_method and nargs != 3) or (not is_method and nargs != 2):
raise ValueError(
"Invalid stop criteria: {}. Callable "
"criteria must take exactly 2 parameters.".format(stop))
config = config or {}
run_identifier = Experiment._register_if_needed(run)