wassname/ray
1
0
Fork 0
mirror of https://github.com/wassname/ray.git synced 2026-06-28 22:20:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

[flaky test] Fix test_calling_start_ray_head (#5644)

Browse Source
This commit is contained in:
Edward Oakes
2019-09-14 22:27:45 -07:00
committed by Philipp Moritz
parent 74a34b736d
commit a8888c5ff4
4 changed files with 106 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/ray/scripts/scripts.py
+4 -4
View File
@@ -9,6 +9,7 @@ import logging
import os
import subprocess
import sys
import time
import ray.services as services
from ray.autoscaler.commands import (
@@ -314,7 +315,7 @@ def start(node_ip_address, redis_address, address, redis_port,
include_java=False,
)
node = ray.node.Node(ray_params, head=True, shutdown_at_exit=False)
node = ray.node.Node(ray_params, head=True, shutdown_at_exit=block)
redis_address = node.redis_address
logger.info(
@@ -384,13 +385,12 @@ def start(node_ip_address, redis_address, address, redis_port,
check_no_existing_redis_clients(ray_params.node_ip_address,
redis_client)
ray_params.update(redis_address=redis_address)
node = ray.node.Node(ray_params, head=False, shutdown_at_exit=False)
node = ray.node.Node(ray_params, head=False, shutdown_at_exit=block)
logger.info("\nStarted Ray on this node. If you wish to terminate the "
"processes that have been started, run\n\n"
" ray stop")
if block:
import time
while True:
time.sleep(1)
deceased = node.dead_processes()
@@ -399,8 +399,8 @@ def start(node_ip_address, redis_address, address, redis_port,
for process_type, process in deceased:
logger.error("\t{} died with exit code {}".format(
process_type, process.returncode))
# shutdown_at_exit will handle cleanup.
logger.error("Killing remaining processes and exiting...")
node.kill_all_processes(check_alive=False, allow_graceful=True)
sys.exit(1)