From af5252901ad38af1a0f0ef60f66bd911e76b0b5b Mon Sep 17 00:00:00 2001 From: Alex Wu Date: Thu, 29 Oct 2020 23:13:25 -0700 Subject: [PATCH] [release] Do not tag docker latest on release builds (#11694) * fix * Added comment Co-authored-by: Alex Wu --- ci/travis/build-docker-images.py | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/ci/travis/build-docker-images.py b/ci/travis/build-docker-images.py index 08c17e92f..b030b3413 100644 --- a/ci/travis/build-docker-images.py +++ b/ci/travis/build-docker-images.py @@ -232,9 +232,13 @@ def push_and_tag_images(push_base_images: bool): for arch_tag in ["-cpu", "-gpu", ""]: full_arch_tag = f"nightly{arch_tag}" - # Tag and push rayproject/:nightly - docker_push(full_image, full_arch_tag) + # Do not tag release builds because they are no longer up to date + # after the branch cut. + if not _release_build(): + # Tag and push rayproject/:nightly + docker_push(full_image, full_arch_tag) + # Ex: specific_tag == "1.0.1" or "" or "" specific_tag = get_new_tag( full_arch_tag, date_tag if "-deps" in image else sha_tag) # Tag and push rayproject/: @@ -244,15 +248,6 @@ def push_and_tag_images(push_base_images: bool): tag=specific_tag) docker_push(full_image, specific_tag) - if _release_build(): - latest_tag = get_new_tag(full_arch_tag, "latest") - # Tag and push rayproject/:latest - DOCKER_CLIENT.api.tag( - image=f"{full_image}:{full_arch_tag}", - repository=full_image, - tag=latest_tag) - docker_push(full_image, latest_tag) - # Build base-deps/ray-deps only on file change, 2 weeks, per release # Build ray, ray-ml, autoscaler every time