From b58e4b5ee4c8c48e082045a5a9ce8e544ec8a516 Mon Sep 17 00:00:00 2001 From: Alex Wu Date: Mon, 3 Aug 2020 12:52:24 -0700 Subject: [PATCH] [Core] Fix test_logging_to_driver (#9829) * Fixed * . * . Co-authored-by: Ubuntu --- python/ray/tests/test_advanced_3.py | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/python/ray/tests/test_advanced_3.py b/python/ray/tests/test_advanced_3.py index 1ce9e826e..276ebd552 100644 --- a/python/ray/tests/test_advanced_3.py +++ b/python/ray/tests/test_advanced_3.py @@ -211,14 +211,9 @@ def test_logging_to_driver(shutdown_only): ray.get(f.remote()) time.sleep(1) - output_lines = captured["out"] + err_lines = captured["err"] for i in range(200): - assert str(i) in output_lines - - # TODO(rkn): Check that no additional logs appear beyond what we expect - # and that there are no duplicate logs. Once we address the issue - # described in https://github.com/ray-project/ray/pull/5462, we should - # also check that nothing is logged to stderr. + assert str(i) in err_lines def test_not_logging_to_driver(shutdown_only): @@ -240,10 +235,8 @@ def test_not_logging_to_driver(shutdown_only): output_lines = captured["out"] assert len(output_lines) == 0 - # TODO(rkn): Check that no additional logs appear beyond what we expect - # and that there are no duplicate logs. Once we address the issue - # described in https://github.com/ray-project/ray/pull/5462, we should - # also check that nothing is logged to stderr. + err_lines = captured["err"] + assert len(err_lines) == 0 @pytest.mark.skipif(