wassname/ray
1
0
Fork 0
mirror of https://github.com/wassname/ray.git synced 2026-06-30 19:42:47 +08:00
Code Issues Packages Projects Releases Wiki Activity

[Tune] remove whitelist from deep_copy (#8997)

Browse Source
This commit is contained in:
Ian Rodney
2020-06-22 15:02:27 -07:00
committed by GitHub
parent f95ab4f506
commit b942bcd798
1 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/ray/tune/utils/util.py
+9 -9
View File
@@ -154,26 +154,26 @@ def merge_dicts(d1, d2):
def deep_update(original,
new_dict,
new_keys_allowed=False,
whitelist=None,
allow_new_subkey_list=None,
override_all_if_type_changes=None):
"""Updates original dict with values from new_dict recursively.
If new key is introduced in new_dict, then if new_keys_allowed is not
True, an error will be thrown. Further, for sub-dicts, if the key is
in the whitelist, then new subkeys can be introduced.
in the allow_new_subkey_list, then new subkeys can be introduced.
Args:
original (dict): Dictionary with default values.
new_dict (dict): Dictionary with values to be updated
new_keys_allowed (bool): Whether new keys are allowed.
whitelist (Optional[List[str]]): List of keys that correspond to dict
values where new subkeys can be introduced. This is only at the top
level.
allow_new_subkey_list (Optional[List[str]]): List of keys that
correspond to dict values where new subkeys can be introduced.
This is only at the top level.
override_all_if_type_changes(Optional[List[str]]): List of top level
keys with value=dict, for which we always simply override the
entire value (dict), iff the "type" key in that value dict changes.
"""
whitelist = whitelist or []
allow_new_subkey_list = allow_new_subkey_list or []
override_all_if_type_changes = override_all_if_type_changes or []
for k, value in new_dict.items():
@@ -187,10 +187,10 @@ def deep_update(original,
"type" in value and "type" in original[k] and \
value["type"] != original[k]["type"]:
original[k] = value
# Whitelisted key -> ok to add new subkeys.
elif k in whitelist:
# Allowed key -> ok to add new subkeys.
elif k in allow_new_subkey_list:
deep_update(original[k], value, True)
# Non-whitelisted key.
# Non-allowed key.
else:
deep_update(original[k], value, new_keys_allowed)
# Original value not a dict OR new value not a dict: