From c2499c802f52b1a5f23dd4cce20c7335aaff1418 Mon Sep 17 00:00:00 2001 From: Kai Yang Date: Sun, 15 Dec 2019 17:54:31 +0800 Subject: [PATCH] disable actor checkpointing and reconstruction test in direct call mode (#6490) --- .../java/org/ray/api/test/ActorReconstructionTest.java | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/java/test/src/main/java/org/ray/api/test/ActorReconstructionTest.java b/java/test/src/main/java/org/ray/api/test/ActorReconstructionTest.java index 43ccfe0ff..00cc1e385 100644 --- a/java/test/src/main/java/org/ray/api/test/ActorReconstructionTest.java +++ b/java/test/src/main/java/org/ray/api/test/ActorReconstructionTest.java @@ -47,6 +47,9 @@ public class ActorReconstructionTest extends BaseTest { public void testActorReconstruction() throws InterruptedException, IOException { TestUtils.skipTestUnderSingleProcess(); + // TODO (kfstorm): Actor reconstruction is currently not supporeted in direct actor call mode. + // Will re-enable the test once the issue got fixed. + TestUtils.skipTestIfDirectActorCallEnabled(); ActorCreationOptions options = new ActorCreationOptions.Builder().setMaxReconstructions(1).createActorCreationOptions(); RayActor actor = Ray.createActor(Counter::new, options); @@ -127,6 +130,10 @@ public class ActorReconstructionTest extends BaseTest { public void testActorCheckpointing() throws IOException, InterruptedException { TestUtils.skipTestUnderSingleProcess(); + // TODO (kfstorm): In direct actor call mode, the actor creation task is not pushed to raylet. + // But to save an actor checkpoint, raylet needs to know about this the actor. Will re-enable + // the test once the issue got fixed. + TestUtils.skipTestIfDirectActorCallEnabled(); ActorCreationOptions options = new ActorCreationOptions.Builder().setMaxReconstructions(1).createActorCreationOptions(); RayActor actor = Ray.createActor(CheckpointableCounter::new, options);