diff --git a/python/ray/rllib/agents/ddpg/ddpg_policy_graph.py b/python/ray/rllib/agents/ddpg/ddpg_policy_graph.py index 52b7593f2..6c4917ad8 100644 --- a/python/ray/rllib/agents/ddpg/ddpg_policy_graph.py +++ b/python/ray/rllib/agents/ddpg/ddpg_policy_graph.py @@ -166,8 +166,9 @@ class DDPGPolicyGraph(DDPGPostprocessing, TFPolicyGraph): stddev=self.config["target_noise"]), -target_noise_clip, target_noise_clip) policy_tp1_smoothed = tf.clip_by_value( - policy_tp1 + clipped_normal_sample, action_space.low, - action_space.high) + policy_tp1 + clipped_normal_sample, + action_space.low * tf.ones_like(policy_tp1), + action_space.high * tf.ones_like(policy_tp1)) else: # no smoothing, just use deterministic actions policy_tp1_smoothed = policy_tp1 @@ -473,8 +474,9 @@ class DDPGPolicyGraph(DDPGPostprocessing, TFPolicyGraph): tf.shape(deterministic_actions), stddev=self.config["exploration_gaussian_sigma"]) stochastic_actions = tf.clip_by_value( - deterministic_actions + normal_sample, action_low, - action_high) + deterministic_actions + normal_sample, + action_low * tf.ones_like(deterministic_actions), + action_high * tf.ones_like(deterministic_actions)) elif noise_type == "ou": # add OU noise for exploration, DDPG-style zero_acts = action_low.size * [.0] @@ -494,7 +496,9 @@ class DDPGPolicyGraph(DDPGPostprocessing, TFPolicyGraph): noise = noise_scale * base_scale \ * exploration_value * action_range stochastic_actions = tf.clip_by_value( - deterministic_actions + noise, action_low, action_high) + deterministic_actions + noise, + action_low * tf.ones_like(deterministic_actions), + action_high * tf.ones_like(deterministic_actions)) else: raise ValueError( "Unknown noise type '%s' (try 'ou' or 'gaussian')" % diff --git a/python/ray/rllib/utils/tf_run_builder.py b/python/ray/rllib/utils/tf_run_builder.py index 4694c96c0..ed4525ddf 100644 --- a/python/ray/rllib/utils/tf_run_builder.py +++ b/python/ray/rllib/utils/tf_run_builder.py @@ -47,6 +47,8 @@ class TFRunBuilder(object): self.session, self.fetches, self.debug_name, self.feed_dict, os.environ.get("TF_TIMELINE_DIR")) except Exception: + logger.exception("Error fetching: {}, feed_dict={}".format( + self.fetches, self.feed_dict)) raise ValueError("Error fetching: {}, feed_dict={}".format( self.fetches, self.feed_dict)) if isinstance(to_fetch, int):