From cb91fe2fc4868710efd97590d9757b7e15b714b3 Mon Sep 17 00:00:00 2001
From: mehrdadn <mehrdadn@users.noreply.github.com>
Date: Fri, 29 May 2020 08:18:20 -0700
Subject: [PATCH] SetErrorMode for all Ray processes (#8656)

---
 src/ray/raylet/worker_pool.cc | 7 +------
 src/ray/util/logging.cc       | 6 ++++++
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/src/ray/raylet/worker_pool.cc b/src/ray/raylet/worker_pool.cc
index fed72a2ab..ad24c9f2d 100644
--- a/src/ray/raylet/worker_pool.cc
+++ b/src/ray/raylet/worker_pool.cc
@@ -66,12 +66,7 @@ WorkerPool::WorkerPool(boost::asio::io_service &io_service, int num_workers,
       raylet_config_(raylet_config),
       starting_worker_timeout_callback_(starting_worker_timeout_callback) {
   RAY_CHECK(maximum_startup_concurrency > 0);
-#ifdef _WIN32
-  // If worker processes fail to initialize, don't display an error window.
-  SetErrorMode(GetErrorMode() | SEM_FAILCRITICALERRORS);
-  // If worker processes crash, don't display an error window.
-  SetErrorMode(GetErrorMode() | SEM_NOGPFAULTERRORBOX);
-#else
+#ifndef _WIN32
   // Ignore SIGCHLD signals. If we don't do this, then worker processes will
   // become zombies instead of dying gracefully.
   signal(SIGCHLD, SIG_IGN);
diff --git a/src/ray/util/logging.cc b/src/ray/util/logging.cc
index 8ab4fe0fd..eeacf3bdd 100644
--- a/src/ray/util/logging.cc
+++ b/src/ray/util/logging.cc
@@ -214,6 +214,12 @@ void RayLog::ShutDownRayLog() {
 }
 
 void RayLog::InstallFailureSignalHandler() {
+#ifdef _WIN32
+  // If process fails to initialize, don't display an error window.
+  SetErrorMode(GetErrorMode() | SEM_FAILCRITICALERRORS);
+  // If process crashes, don't display an error window.
+  SetErrorMode(GetErrorMode() | SEM_NOGPFAULTERRORBOX);
+#endif
 #ifdef RAY_USE_GLOG
   if (is_failure_signal_handler_installed_) {
     return;